Commit 67e4e691 authored by Fredrik Söderquist's avatar Fredrik Söderquist Committed by Commit Bot

Remove SVGSMILElement::animated_property_locked_

We check this member field, but we never set it, so it's of no use
anymore.

Bug: 998526
Change-Id: I6de7399574828fe26f413d0dfcd2a0556540f4c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1831767Reviewed-by: default avatarStephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#701462}
parent aab2a58e
...@@ -118,16 +118,6 @@ class CORE_EXPORT SVGSMILElement : public SVGElement, public SVGTests { ...@@ -118,16 +118,6 @@ class CORE_EXPORT SVGSMILElement : public SVGElement, public SVGTests {
// animations are rendered useless. // animations are rendered useless.
virtual bool OverwritesUnderlyingAnimationValue() const = 0; virtual bool OverwritesUnderlyingAnimationValue() const = 0;
bool AnimatedTypeIsLocked() const { return animated_property_locked_; }
void LockAnimatedType() {
DCHECK(!animated_property_locked_);
animated_property_locked_ = true;
}
void UnlockAnimatedType() {
DCHECK(animated_property_locked_);
animated_property_locked_ = false;
}
void ScheduleEvent(const AtomicString& event_type); void ScheduleEvent(const AtomicString& event_type);
void ScheduleRepeatEvents(); void ScheduleRepeatEvents();
void DispatchPendingEvent(const AtomicString& event_type); void DispatchPendingEvent(const AtomicString& event_type);
...@@ -287,7 +277,6 @@ class CORE_EXPORT SVGSMILElement : public SVGElement, public SVGTests { ...@@ -287,7 +277,6 @@ class CORE_EXPORT SVGSMILElement : public SVGElement, public SVGTests {
mutable SMILTime cached_min_; mutable SMILTime cached_min_;
mutable SMILTime cached_max_; mutable SMILTime cached_max_;
bool animated_property_locked_;
bool interval_has_changed_; bool interval_has_changed_;
friend class ConditionEventListener; friend class ConditionEventListener;
......
...@@ -443,12 +443,6 @@ void SVGAnimateElement::ClearAnimatedType() { ...@@ -443,12 +443,6 @@ void SVGAnimateElement::ClearAnimatedType() {
if (!animated_value_) if (!animated_value_)
return; return;
// The animated property lock is held for the "result animation" (see
// SMILTimeContainer::updateAnimations()) while we're processing an animation
// group. We will very likely crash later if we clear the animated type while
// the lock is held. See crbug.com/581546.
DCHECK(!AnimatedTypeIsLocked());
SVGElement* target_element = targetElement(); SVGElement* target_element = targetElement();
if (!target_element) { if (!target_element) {
animated_value_.Clear(); animated_value_.Clear();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment