Commit 67ed2649 authored by Tanmoy Mollik's avatar Tanmoy Mollik Committed by Commit Bot

Don't abort signin in SigninManager after onSystemAccountsChanged

It doesn't make much sense to abort sign-in if some other account was
updated. Moreover, SigninManager doesn't expect sign-in to be aborted at
random moments, so it might be left in an unconsistent state. This cl
removes onSystemAccountsChanged() method altogether as it just calls the
abortSignIn() method inside it.

Bug: 1059422
Change-Id: I1320ca10e93879665493473f2eb74148f30c580b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2094298Reviewed-by: default avatarAlice Wang <aliceywang@chromium.org>
Reviewed-by: default avatarBoris Sazonov <bsazonov@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#750933}
parent d4f88da6
......@@ -351,16 +351,6 @@ public class SigninManager
}
}
/**
* Clear pending sign in when system accounts in AccountTrackerService were refreshed.
*/
@Override
public void onSystemAccountsChanged() {
if (mSignInState != null) {
abortSignIn();
}
}
/**
* Starts the sign-in flow, and executes the callback when finished.
*
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment