Commit 67f01ddf authored by gajendra.n's avatar gajendra.n Committed by Commit bot

Do not present poof animation while drag & drop a bookmark in the chevron-menu.

For offTheSideButton, animation was always enabled regardless of nodeMoved/
nodeRemoved. Enable animation only when it is called from -nodeRemoved:,
decided by 'animate' parameter.

BUG=60628
R=asvitkine@chromium.org

TEST=
1. Launch chrome and add more bookmarks and folders so that chevron is seen.
2. Drag and adjust items so that there is atleast one folder and one or more bookmarks under chevron.
3. Drag a bookmark(within chevron) and drop it under the folder(within chevron) and observe.
4. There should be no poof animation/sound presented to see/hear.

Review URL: https://codereview.chromium.org/599793002

Cr-Commit-Position: refs/heads/master@{#297105}
parent 8ff9db81
...@@ -2806,7 +2806,7 @@ static BOOL ValueInRangeInclusive(CGFloat low, CGFloat value, CGFloat high) { ...@@ -2806,7 +2806,7 @@ static BOOL ValueInRangeInclusive(CGFloat low, CGFloat value, CGFloat high) {
// The button being removed is in the OTS (off-the-side) and the OTS // The button being removed is in the OTS (off-the-side) and the OTS
// menu is showing so we need to remove the button. // menu is showing so we need to remove the button.
NSInteger index = buttonIndex - displayedButtonCount_; NSInteger index = buttonIndex - displayedButtonCount_;
[folderController_ removeButton:index animate:YES]; [folderController_ removeButton:index animate:animate];
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment