Commit 67f19ea1 authored by Piotr Bialecki's avatar Piotr Bialecki Committed by Commit Bot

Add XRSpace::ToString() to aid investigations

Change-Id: I3e5327e70bc910f3eaa7b33eea1c0f1ddeda2fc0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495970Reviewed-by: default avatarAlexander Cooper <alcooper@chromium.org>
Reviewed-by: default avatarBrandon Jones <bajones@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#820942}
parent 6c4067c6
......@@ -1056,6 +1056,8 @@ ArCoreImpl::GetMojoFromInputSources(
base::Optional<gfx::Transform> ArCoreImpl::GetMojoFromReferenceSpace(
device::mojom::XRReferenceSpaceType type,
const gfx::Transform& mojo_from_viewer) {
DVLOG(3) << __func__ << ": type=" << type;
switch (type) {
case device::mojom::XRReferenceSpaceType::kLocal:
return gfx::Transform{};
......
......@@ -274,6 +274,8 @@ ScriptPromise XRFrame::createAnchor(ScriptState* script_state,
return {};
}
DVLOG(3) << __func__ << ": space->ToString()=" << space->ToString();
// The passed in space may be an offset space, we need to transform the pose
// to account for origin-offset:
auto native_origin_from_offset_space = space->NativeFromOffsetMatrix();
......
......@@ -46,6 +46,10 @@ bool XRGripSpace::IsStationary() const {
return false;
}
std::string XRGripSpace::ToString() const {
return "XRGripSpace";
}
void XRGripSpace::Trace(Visitor* visitor) const {
visitor->Trace(input_source_);
XRSpace::Trace(visitor);
......
......@@ -22,6 +22,8 @@ class XRGripSpace : public XRSpace {
bool IsStationary() const override;
std::string ToString() const override;
void Trace(Visitor*) const override;
private:
......
......@@ -44,6 +44,8 @@ class XRObjectSpace : public XRSpace {
return true;
}
std::string ToString() const override { return "XRObjectSpace"; }
void Trace(Visitor* visitor) const override {
visitor->Trace(object_);
XRSpace::Trace(visitor);
......
......@@ -4,6 +4,8 @@
#include "third_party/blink/renderer/modules/xr/xr_reference_space.h"
#include <sstream>
#include "device/vr/public/mojom/vr_service.mojom-blink.h"
#include "third_party/blink/renderer/modules/xr/xr_pose.h"
#include "third_party/blink/renderer/modules/xr/xr_reference_space_event.h"
......@@ -197,6 +199,14 @@ XRReferenceSpace::NativeOrigin() const {
return XRNativeOriginInformation::Create(this);
}
std::string XRReferenceSpace::ToString() const {
std::stringstream ss;
ss << "XRReferenceSpace(type=" << type_ << ")";
return ss.str();
}
void XRReferenceSpace::Trace(Visitor* visitor) const {
visitor->Trace(origin_offset_);
XRSpace::Trace(visitor);
......
......@@ -52,6 +52,8 @@ class XRReferenceSpace : public XRSpace {
base::Optional<device::mojom::blink::XRNativeOriginInformation> NativeOrigin()
const final;
std::string ToString() const override;
void Trace(Visitor*) const override;
virtual void OnReset();
......
......@@ -90,6 +90,9 @@ class XRSpace : public EventTargetWithInlineData {
XRSession* session() const { return session_; }
// ToString() helper, used for debugging.
virtual std::string ToString() const = 0;
// EventTarget overrides.
ExecutionContext* GetExecutionContext() const override;
const AtomicString& InterfaceName() const override;
......
......@@ -55,6 +55,10 @@ XRTargetRaySpace::NativeOrigin() const {
return input_source_->nativeOrigin();
}
std::string XRTargetRaySpace::ToString() const {
return "XRTargetRaySpace";
}
bool XRTargetRaySpace::IsStationary() const {
// Target ray space is a space derived off of input source, so it is not
// considered stationary.
......
......@@ -22,6 +22,8 @@ class XRTargetRaySpace : public XRSpace {
bool IsStationary() const override;
std::string ToString() const override;
void Trace(Visitor*) const override;
private:
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment