Commit 67f7259b authored by jeffm@apple.com's avatar jeffm@apple.com

2011-03-25 Jeff Miller <jeffm@apple.com>

        Reviewed by Darin Adler.

        Add CoreIPC::encodeResourceError() and CoreIPC::decodeResourceError() for all platforms
        https://bugs.webkit.org/show_bug.cgi?id=57125
        
        Currently, these are only implemented on the Mac, but we're going to need them for Windows as well, so we might as well make them always platform-specific.
        In this patch, just replicate the existing common non-Mac implementation in WebCoreArgumentCoders.h to platform-specific files.

        * Shared/WebCoreArgumentCoders.h: Move non-Mac implementations of encodeResourceError() and decodeResourceError() to common files.
        * Shared/gtk/WebCoreArgumentCodersGtk.cpp:
        (CoreIPC::encodeResourceError): Added.
        (CoreIPC::decodeResourceError): Added.
        * Shared/qt/WebCoreArgumentCodersQt.cpp:
        (CoreIPC::encodeResourceError): Added.
        (CoreIPC::decodeResourceError): Added.
        * Shared/win/WebCoreArgumentCodersWin.cpp:
        (CoreIPC::encodeResourceError): Added.
        (CoreIPC::decodeResourceError): Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@82002 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 07382359
2011-03-25 Jeff Miller <jeffm@apple.com>
Reviewed by Darin Adler.
Add CoreIPC::encodeResourceError() and CoreIPC::decodeResourceError() for all platforms
https://bugs.webkit.org/show_bug.cgi?id=57125
Currently, these are only implemented on the Mac, but we're going to need them for Windows as well, so we might as well make them always platform-specific.
In this patch, just replicate the existing common non-Mac implementation in WebCoreArgumentCoders.h to platform-specific files.
* Shared/WebCoreArgumentCoders.h: Move non-Mac implementations of encodeResourceError() and decodeResourceError() to common files.
* Shared/gtk/WebCoreArgumentCodersGtk.cpp:
(CoreIPC::encodeResourceError): Added.
(CoreIPC::decodeResourceError): Added.
* Shared/qt/WebCoreArgumentCodersQt.cpp:
(CoreIPC::encodeResourceError): Added.
(CoreIPC::decodeResourceError): Added.
* Shared/win/WebCoreArgumentCodersWin.cpp:
(CoreIPC::encodeResourceError): Added.
(CoreIPC::decodeResourceError): Added.
2011-03-25 Andy Estes <aestes@apple.com> 2011-03-25 Andy Estes <aestes@apple.com>
Reviewed by Adele Peterson. Reviewed by Adele Peterson.
......
...@@ -277,36 +277,19 @@ template<> struct ArgumentCoder<WebCore::ResourceResponse> { ...@@ -277,36 +277,19 @@ template<> struct ArgumentCoder<WebCore::ResourceResponse> {
} }
}; };
#if PLATFORM(MAC)
// These two functions are implemented in a platform specific manner. // These two functions are implemented in a platform specific manner.
void encodeResourceError(ArgumentEncoder*, const WebCore::ResourceError&); void encodeResourceError(ArgumentEncoder*, const WebCore::ResourceError&);
bool decodeResourceError(ArgumentDecoder*, WebCore::ResourceError&); bool decodeResourceError(ArgumentDecoder*, WebCore::ResourceError&);
#endif
template<> struct ArgumentCoder<WebCore::ResourceError> { template<> struct ArgumentCoder<WebCore::ResourceError> {
static void encode(ArgumentEncoder* encoder, const WebCore::ResourceError& resourceError) static void encode(ArgumentEncoder* encoder, const WebCore::ResourceError& resourceError)
{ {
#if PLATFORM(MAC)
encodeResourceError(encoder, resourceError); encodeResourceError(encoder, resourceError);
#else
encoder->encode(CoreIPC::In(resourceError.domain(), resourceError.errorCode(), resourceError.failingURL(), resourceError.localizedDescription()));
#endif
} }
static bool decode(ArgumentDecoder* decoder, WebCore::ResourceError& resourceError) static bool decode(ArgumentDecoder* decoder, WebCore::ResourceError& resourceError)
{ {
#if PLATFORM(MAC)
return decodeResourceError(decoder, resourceError); return decodeResourceError(decoder, resourceError);
#else
String domain;
int errorCode;
String failingURL;
String localizedDescription;
if (!decoder->decode(CoreIPC::Out(domain, errorCode, failingURL, localizedDescription)))
return false;
resourceError = WebCore::ResourceError(domain, errorCode, failingURL, localizedDescription);
return true;
#endif
} }
}; };
......
...@@ -61,4 +61,21 @@ bool decodeResourceResponse(ArgumentDecoder* decoder, WebCore::ResourceResponse& ...@@ -61,4 +61,21 @@ bool decodeResourceResponse(ArgumentDecoder* decoder, WebCore::ResourceResponse&
return true; return true;
} }
void encodeResourceError(ArgumentEncoder* encoder, const WebCore::ResourceError& resourceError)
{
encoder->encode(CoreIPC::In(resourceError.domain(), resourceError.errorCode(), resourceError.failingURL(), resourceError.localizedDescription()));
}
bool decodeResourceError(ArgumentDecoder* decoder, WebCore::ResourceError& resourceError)
{
String domain;
int errorCode;
String failingURL;
String localizedDescription;
if (!decoder->decode(CoreIPC::Out(domain, errorCode, failingURL, localizedDescription)))
return false;
resourceError = WebCore::ResourceError(domain, errorCode, failingURL, localizedDescription);
return true;
}
} }
...@@ -60,4 +60,21 @@ bool decodeResourceResponse(ArgumentDecoder* decoder, WebCore::ResourceResponse& ...@@ -60,4 +60,21 @@ bool decodeResourceResponse(ArgumentDecoder* decoder, WebCore::ResourceResponse&
return true; return true;
} }
void encodeResourceError(ArgumentEncoder* encoder, const WebCore::ResourceError& resourceError)
{
encoder->encode(CoreIPC::In(resourceError.domain(), resourceError.errorCode(), resourceError.failingURL(), resourceError.localizedDescription()));
}
bool decodeResourceError(ArgumentDecoder* decoder, WebCore::ResourceError& resourceError)
{
String domain;
int errorCode;
String failingURL;
String localizedDescription;
if (!decoder->decode(CoreIPC::Out(domain, errorCode, failingURL, localizedDescription)))
return false;
resourceError = WebCore::ResourceError(domain, errorCode, failingURL, localizedDescription);
return true;
}
} // namespace CoreIPC } // namespace CoreIPC
...@@ -117,4 +117,21 @@ bool decodeResourceResponse(ArgumentDecoder* decoder, WebCore::ResourceResponse& ...@@ -117,4 +117,21 @@ bool decodeResourceResponse(ArgumentDecoder* decoder, WebCore::ResourceResponse&
#endif #endif
} }
void encodeResourceError(ArgumentEncoder* encoder, const WebCore::ResourceError& resourceError)
{
encoder->encode(CoreIPC::In(resourceError.domain(), resourceError.errorCode(), resourceError.failingURL(), resourceError.localizedDescription()));
}
bool decodeResourceError(ArgumentDecoder* decoder, WebCore::ResourceError& resourceError)
{
String domain;
int errorCode;
String failingURL;
String localizedDescription;
if (!decoder->decode(CoreIPC::Out(domain, errorCode, failingURL, localizedDescription)))
return false;
resourceError = WebCore::ResourceError(domain, errorCode, failingURL, localizedDescription);
return true;
}
} // namespace CoreIPC } // namespace CoreIPC
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment