Commit 67f9e9da authored by Maks Orlovich's avatar Maks Orlovich Committed by Commit Bot

SimpleFileTracker: out-of-line some shared histogram code.

This is apparently a good practice since these macros can generate
quite a bit of code, which I didn't know at the time of writing this.

Change-Id: If28af80c07200562f029e2c588ffc5666a5e8326
Reviewed-on: https://chromium-review.googlesource.com/c/1459579Reviewed-by: default avatarEric Orth <ericorth@chromium.org>
Commit-Queue: Maks Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#630117}
parent c5404921
...@@ -17,6 +17,15 @@ ...@@ -17,6 +17,15 @@
namespace disk_cache { namespace disk_cache {
namespace {
void RecordFileDescripterLimiterOp(FileDescriptorLimiterOp op) {
UMA_HISTOGRAM_ENUMERATION("SimpleCache.FileDescriptorLimiterAction", op,
FD_LIMIT_OP_MAX);
}
} // namespace
SimpleFileTracker::SimpleFileTracker(int file_limit) SimpleFileTracker::SimpleFileTracker(int file_limit)
: file_limit_(file_limit) {} : file_limit_(file_limit) {}
...@@ -252,8 +261,7 @@ void SimpleFileTracker::CloseFilesIfTooManyOpen( ...@@ -252,8 +261,7 @@ void SimpleFileTracker::CloseFilesIfTooManyOpen(
tracked_files->files[j] != nullptr) { tracked_files->files[j] != nullptr) {
files_to_close->push_back(std::move(tracked_files->files[j])); files_to_close->push_back(std::move(tracked_files->files[j]));
--open_files_; --open_files_;
UMA_HISTOGRAM_ENUMERATION("SimpleCache.FileDescriptorLimiterAction", RecordFileDescripterLimiterOp(FD_LIMIT_CLOSE_FILE);
FD_LIMIT_CLOSE_FILE, FD_LIMIT_OP_MAX);
} }
} }
...@@ -283,14 +291,12 @@ void SimpleFileTracker::ReopenFile(TrackedFiles* owners_files, ...@@ -283,14 +291,12 @@ void SimpleFileTracker::ReopenFile(TrackedFiles* owners_files,
owners_files->files[file_index] = owners_files->files[file_index] =
std::make_unique<base::File>(file_path, flags); std::make_unique<base::File>(file_path, flags);
if (owners_files->files[file_index]->IsValid()) { if (owners_files->files[file_index]->IsValid()) {
UMA_HISTOGRAM_ENUMERATION("SimpleCache.FileDescriptorLimiterAction", RecordFileDescripterLimiterOp(FD_LIMIT_REOPEN_FILE);
FD_LIMIT_REOPEN_FILE, FD_LIMIT_OP_MAX);
++open_files_; ++open_files_;
} else { } else {
owners_files->files[file_index] = nullptr; owners_files->files[file_index] = nullptr;
UMA_HISTOGRAM_ENUMERATION("SimpleCache.FileDescriptorLimiterAction", RecordFileDescripterLimiterOp(FD_LIMIT_FAIL_REOPEN_FILE);
FD_LIMIT_FAIL_REOPEN_FILE, FD_LIMIT_OP_MAX);
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment