Commit 68222664 authored by Mohamed Amir Yosef's avatar Mohamed Amir Yosef Committed by Chromium LUCI CQ

[Passwords] Show snackbar after moving multiple passwords to the account

Screenshot: https://screenshot.googleplex.com/6Ki84UvdP69rMEX.png

Bug: 1139263
Change-Id: Icdaa25f0abc98affcfffb2e4e717db9bc887cf46
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2595278
Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org>
Reviewed-by: default avatarMarc Treib <treib@chromium.org>
Reviewed-by: default avatarJan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#838152}
parent 99305485
......@@ -33,6 +33,11 @@ Polymer({
accountEmail: String,
},
/** @return {boolean} Whether the user confirmed the dialog. */
wasConfirmed() {
return this.$.dialog.getNative().returnValue === 'success';
},
/** @override */
attached() {
chrome.metricsPrivate.recordEnumerationValue(
......@@ -60,6 +65,6 @@ Polymer({
/** @private */
onCancelButtonClick_() {
this.$.dialog.close();
this.$.dialog.cancel();
},
});
......@@ -95,6 +95,9 @@
</div>
<cr-icon-button iron-icon="cr:open-in-new"></cr-icon-button>
</div>
<cr-toast id="toast" duration="5000">
<div>$i18nRaw{devicePasswordsMoved}</div>
</cr-toast>
<template is="dom-if" if="[[showMoveMultiplePasswordsDialog_]]" restamp>
<password-move-multiple-passwords-to-account-dialog
passwords-to-move="[[allDevicePasswords_]]"
......
......@@ -18,6 +18,7 @@ import './avatar_icon.js';
import './passwords_shared_css.js';
import './password_list_item.js';
import './password_move_multiple_passwords_to_account_dialog.js';
import 'chrome://resources/cr_elements/cr_toast/cr_toast.m.js';
import 'chrome://resources/polymer/v3_0/iron-flex-layout/iron-flex-layout-classes.js';
import 'chrome://resources/polymer/v3_0/iron-list/iron-list.js';
......@@ -366,6 +367,10 @@ Polymer({
/** @private */
onMoveMultiplePasswordsDialogClose_() {
if ((this.$$('password-move-multiple-passwords-to-account-dialog'))
.wasConfirmed()) {
this.$.toast.show();
}
this.showMoveMultiplePasswordsDialog_ = false;
},
......
......@@ -1003,6 +1003,8 @@ void AddAutofillStrings(content::WebUIDataSource* html_source,
{"passwordRemoveDialogFromDeviceCheckboxLabel",
IDS_SETTINGS_PASSWORD_REMOVE_DIALOG_FROM_DEVICE_CHECKBOX_LABEL},
{"devicePasswordsLinkLabel", IDS_SETTINGS_DEVICE_PASSWORDS_LINK_LABEL},
{"devicePasswordsMoved",
IDS_SETTINGS_PASSWORD_MOVE_PASSWORDS_TO_ACCOUNT_SNACKBAR},
{"passwordRowMoreActionsButton", IDS_SETTINGS_PASSWORD_ROW_MORE_ACTIONS},
{"passwordRowFederatedMoreActionsButton",
IDS_SETTINGS_PASSWORD_ROW_FEDERATED_MORE_ACTIONS},
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment