Skip to content

GitLab

T
tangled
Commit 684786e8 authored by noel's avatar noel Committed by Commit bot
Browse files
Options

Make fast/images/size-failure.html not crash 

Make the GIF resource image 1024x1024 to avoid OOM on Android, Linux,
and XP bots (this is not a crash test).

TBR=wangxianzhu@chromium.org
NOTRY=true
BUG=501543

Review URL: https://codereview.chromium.org/1549253002

Cr-Commit-Position: refs/heads/master@{#366921}
parent e7c76f3d
Hide whitespace changes
Inline Side-by-side
Showing with 26 additions and 24 deletions
third_party/WebKit/LayoutTests/TestExpectations
View file @ 684786e8
......@@ -198,7 +198,6 @@ crbug.com/248938 virtual/threaded/transitions/start-transform-transition.html [
crbug.com/248938 virtual/threaded/animations/animation-direction-normal.html [ Pass Failure Timeout ]
crbug.com/248938 virtual/threaded/animations/animation-iteration-event-destroy-renderer.html [ Pass Timeout ]
crbug.com/248938 virtual/threaded/animations/transition-and-animation-3.html [ Pass Timeout ]
crbug.com/501543 fast/images/size-failure.html [ Crash Timeout Pass ]
crbug.com/446385 [ Linux Mac ] http/tests/xmlhttprequest/xmlhttprequest-json-response-overflow.html [ Pass Timeout ]
crbug.com/446385 [ Win7 Debug ] http/tests/xmlhttprequest/xmlhttprequest-json-response-overflow.html [ Crash Pass Timeout ]
crbug.com/441705 fast/media/media-svg-crash.html [ Pass Failure ]
......@@ -227,6 +226,8 @@ crbug.com/542541 [ Debug ] fast/events/click-count.html [ Pass Failure ]
crbug.com/542541 [ Debug ] virtual/trustedeventsdefaultaction/fast/events/click-count.html [ Pass Failure ]
crbug.com/542541 [ Debug ] virtual/pointerevent/fast/events/click-count.html [ Pass Failure ]
crbug.com/501543 fast/images/size-failure.html [ Crash Timeout Pass ]
# FIXME issue 570401, FIXME dsf2 is an abbrv, fix the test name per style.
crbug.com/495750 fast/hidpi/calendar-picker-appearance-dsf2-with-zoom.html [ Skip ]
crbug.com/495750 fast/hidpi/calendar-picker-appearance-dsf2.html [ Skip ]
......
third_party/WebKit/LayoutTests/fast/images/size-failure.html
View file @ 684786e8
<html>
<head>
<script>
if (window.testRunner) {
testRunner.dumpAsText();
testRunner.waitUntilDone();
<head>
<script>
if (window.testRunner) {
testRunner.dumpAsText();
testRunner.waitUntilDone();
}
// Force a pixel dump to cover raterization issues if any.
onload = function() {
testRunner.capturePixelsAsyncThen(function() {
testRunner.notifyDone();
});
};
}
</script>
</head>
<body>
<!-- This previously tried to read the size of the image when
ImageDecoder::m_failed was true, triggering either an assert or a
read of random memory. Thanks to Robert Swiecki for the test case. -->
<img src="resources/size-failure.gif">
<p>PASS</p>
</body>
</html>
window.onload = function() {
if (!window.testRunner)
return;
// Force a pixel dump to cover raterization issues if any.
window.testRunner.capturePixelsAsyncThen(function() {
window.testRunner.notifyDone();
});
};
</script>
</head>
<body>
<!-- This previously tried to read the size of the image when
ImageDecoder::m_failed was true, triggering either an assert or a
read of random memory. Thanks to Robert Swiecki for the test case. -->
<img src="resources/size-failure.gif">
<p>PASS</p>
</body>
</html>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment