Skip to content

GitLab

T
tangled
Commit 6862f77d authored by Sriram's avatar Sriram Committed by Commit Bot
Browse files
Options

Remove default padding for cue text rendering 

Per spec there is no default padding for text track cue rendering.
Removing the default padding for cue text.

BUG=930608, 843136

Change-Id: If931c1faff528a87d8a78808f30225ebe2377072
Reviewed-on: https://chromium-review.googlesource.com/c/1475567
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Reviewed-by: default avatarMounir Lamouri <mlamouri@chromium.org>
Reviewed-by: default avatarFredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#633624}
parent 9e484bed
Hide whitespace changes
Inline Side-by-side
Showing with 51 additions and 20 deletions
third_party/blink/renderer/modules/media_controls/resources/legacyMediaControls.css
View file @ 6862f77d
......@@ -638,7 +638,6 @@ video::cue {
display: inline;
background-color: rgba(0, 0, 0, 0.8);
padding: 2px 2px;
}
video::-webkit-media-text-track-region {
......
third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css
View file @ 6862f77d
......@@ -1168,7 +1168,6 @@ video::cue {
display: inline;
background-color: rgba(0, 0, 0, 0.8);
padding: 2px 2px;
}
video::-webkit-media-text-track-region {
......
third_party/blink/web_tests/external/wpt/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-empty-cue-ref.html 0 → 100644
View file @ 6862f77d
<!DOCTYPE html>
<html class="reftest-wait">
<title>Reference for track rendering with empty cue</title>
<script src="/common/reftest-wait.js"></script>
<style>
html { overflow:hidden }
body { margin:0 }
.container {
display: inline-block;
position: relative;
}
</style>
<div class="container">
<video width="320" height="180">
<source src="/media/white.webm" type="video/webm">
<source src="/media/white.mp4" type="video/mp4">
<script>
var video = document.querySelector("video");
video.addEventListener('playing', () => {
video.pause();
takeScreenshot();
}, { once: true});
video.play();
</script>
</video>
</div>
</html>
\ No newline at end of file
third_party/blink/web_tests/external/wpt/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-empty-cue.html
View file @ 6862f77d
<!DOCTYPE html>
<title>Empty cues</title>
<script src="/common/media.js"></script>
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script>
async_test(function(t) {
var video = document.createElement("video");
video.src = getVideoURI("/media/test");
video.addTextTrack("captions", "regular captions track", "en");
video.textTracks[0].addCue(new VTTCue(0, 4, ""));
<html class="reftest-wait">
<title>Track rendering with empty cue</title>
<link rel="match" href="track-cue-rendering-empty-cue-ref.html">
<style>
html { overflow:hidden }
body { margin:0 }
</style>
<script src="/common/reftest-wait.js"></script>
<video width="320" height="180">
<source src="/media/white.webm" type="video/webm">
<source src="/media/white.mp4" type="video/mp4">
<script>
var video = document.querySelector("video");
var track = video.addTextTrack("captions", "regular captions track", "en");
track.addCue(new VTTCue(0, 4, ""));
track.mode = "showing";
video.onplaying = t.step_func_done();
video.addEventListener('playing', () => {
video.pause();
takeScreenshot();
}, { once: true});
video.play();
});
</script>
\ No newline at end of file
</script>
</video>
</html>
\ No newline at end of file
third_party/blink/web_tests/external/wpt/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-line-doesnt-fit-ref.html
View file @ 6862f77d
......@@ -20,7 +20,6 @@
background: green;
color: green;
font-size: 120px;
padding: 2px;
}
</style>
<div class="container">
......
third_party/blink/web_tests/external/wpt/html/semantics/embedded-content/media-elements/track/track-element/track-cue-rendering-transformed-video-ref.html
View file @ 6862f77d
......@@ -22,7 +22,6 @@
background: green;
color: green;
font-size: 50px;
padding: 2px;
}
</style>
<div class="container">
......
third_party/blink/web_tests/media/track/track-cue-rendering-position-auto-expected.html
View file @ 6862f77d
......@@ -30,7 +30,6 @@ var mediaFile = '../content/test.ogv';
background: green;
color: green;
font-size: 50px;
padding: 2px;
}
</style>
<div class="container">
......
third_party/blink/web_tests/media/track/track-cue-rendering-position-auto-rtl-expected.html
View file @ 6862f77d
......@@ -32,7 +32,6 @@ var mediaFile = '../content/test.ogv';
background: green;
color: green;
font-size: 50px;
padding: 2px;
}
</style>
<div class="container">
......
third_party/blink/web_tests/media/track/track-cue-rendering-with-padding.html
View file @ 6862f77d
......@@ -5,7 +5,7 @@
<script src="../../resources/testharnessreport.js"></script>
<style>
video::-webkit-media-text-track-display {
padding: 15px;
padding: 10px;
}
</style>
<video>
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment