Polish idle time spell checker's typing progress checking algorithm

This patch makes idle time spell checker consider the possibility of typing in a partial word even with closed typing command, so that we won't be marking partial words due to JS closing typing command in the middle of typing. Bug: 749934 Change-Id: I426392adf69c30803a5c6de475680c2c9d55cfc5 Reviewed-on: https://chromium-review.googlesource.com/592789 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491959}

Polish idle time spell checker's typing progress checking algorithm
This patch makes idle time spell checker consider the possibility of typing in a partial word even with closed typing command, so that we won't be marking partial words due to JS closing typing command in the middle of typing. Bug: 749934 Change-Id: I426392adf69c30803a5c6de475680c2c9d55cfc5 Reviewed-on: https://chromium-review.googlesource.com/592789 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#491959}
6869f052 · Xiaocheng Hu · Commit Bot · f6ca6cc7 · 6869f052 · 6869f052
Commit 6869f052 authored Aug 04, 2017 by Xiaocheng Hu Committed by Commit Bot Aug 04, 2017
2 changed files
--- a/third_party/WebKit/LayoutTests/editing/spelling/close_typing_in_partial_word.html
+++ b/third_party/WebKit/LayoutTests/editing/spelling/close_typing_in_partial_word.html
+<!doctype html>
+<script src="../../resources/testharness.js"></script>
+<script src="../../resources/testharnessreport.js"></script>
+<script src="../assert_selection.js"></script>
+<script src="spellcheck_test.js"></script>
+<script>
+// Regression test for crbug.com/749934
+spellcheck_test(
+    '<div contenteditable>|</div>',
+    document => {
+      const div = document.querySelector('div');
+      const selection = document.getSelection();
+      document.execCommand('insertText', false, 'zz');
+      selection.collapse(div.firstChild, 2); // Closes typing
+    },
+    '<div contenteditable>zz</div>',
+    'Do not check partial word even if the last typing command is closed');
+</script>
--- a/third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.cpp
+++ b/third_party/WebKit/Source/core/editing/spellcheck/HotModeSpellCheckRequester.cpp
@@ -44,11 +44,12 @@ EphemeralRange CurrentWordIfTypingInPartialWord(const Element& editable) {
  if (RootEditableElementOf(selection.Base()) != &editable)
    return EphemeralRange();
-  CompositeEditCommand* typing_command =
+  CompositeEditCommand* last_command = frame.GetEditor().LastEditCommand();
-      frame.GetEditor().LastTypingCommandIfStillOpenForTyping();
+  if (!last_command || !last_command->IsTypingCommand())
-  if (!typing_command)
    return EphemeralRange();
-  if (typing_command->EndingVisibleSelection().AsSelection() != selection)
+  if (!last_command->EndingSelection().IsValidFor(*frame.GetDocument()))
+    return EphemeralRange();
+  if (last_command->EndingSelection().AsSelection() != selection)
    return EphemeralRange();
  return AdjacentWordIfExists(selection.Base());
 }