Move test method from PowerManagerClient to FakePowerManagerClient

Bug: 644348
Change-Id: I420883c7ce6e61783fd56fd94e044f5e59291b31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1526485Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#641706}

chrome/browser/chromeos/power/extension_event_observer_unittest.cc

@@ -142,22 +142,22 @@ TEST_F(ExtensionEventObserverTest, BasicSuspendAndDarkSuspend) {
       power_manager::SuspendImminent_Reason_OTHER);
   EXPECT_EQ(
       1,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 
   EXPECT_TRUE(test_api_->MaybeRunSuspendReadinessCallback());
   EXPECT_EQ(
       0,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 
   FakePowerManagerClient::Get()->SendDarkSuspendImminent();
   EXPECT_EQ(
       1,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 
   EXPECT_TRUE(test_api_->MaybeRunSuspendReadinessCallback());
   EXPECT_EQ(
       0,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 }
 
 // Tests that the ExtensionEventObserver properly handles a canceled suspend
@@ -167,7 +167,7 @@ TEST_F(ExtensionEventObserverTest, CanceledSuspend) {
       power_manager::SuspendImminent_Reason_OTHER);
   EXPECT_EQ(
       1,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 
   FakePowerManagerClient::Get()->SendSuspendDone();
   EXPECT_FALSE(test_api_->MaybeRunSuspendReadinessCallback());
@@ -193,12 +193,12 @@ TEST_F(ExtensionEventObserverTest, PushMessagesDelaySuspend) {
   EXPECT_TRUE(test_api_->MaybeRunSuspendReadinessCallback());
   EXPECT_EQ(
       1,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 
   extension_event_observer_->OnBackgroundEventAcked(host, kSuspendPushId);
   EXPECT_EQ(
       0,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 
   // Now test receiving the suspend attempt before the push message.
   const int kDarkSuspendPushId = 56674;
@@ -209,12 +209,12 @@ TEST_F(ExtensionEventObserverTest, PushMessagesDelaySuspend) {
   EXPECT_TRUE(test_api_->MaybeRunSuspendReadinessCallback());
   EXPECT_EQ(
       1,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 
   extension_event_observer_->OnBackgroundEventAcked(host, kDarkSuspendPushId);
   EXPECT_EQ(
       0,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 
   // Test that non-push messages do not delay the suspend.
   const int kNonPushId = 5687;
@@ -225,7 +225,7 @@ TEST_F(ExtensionEventObserverTest, PushMessagesDelaySuspend) {
   EXPECT_TRUE(test_api_->MaybeRunSuspendReadinessCallback());
   EXPECT_EQ(
       0,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 }
 
 // Tests that messages sent for apps that don't use GCM are ignored.
@@ -241,7 +241,7 @@ TEST_F(ExtensionEventObserverTest, IgnoresNonGCMApps) {
   EXPECT_TRUE(test_api_->MaybeRunSuspendReadinessCallback());
   EXPECT_EQ(
       0,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 }
 
 // Tests that network requests started by an app while it is processing a push
@@ -263,7 +263,7 @@ TEST_F(ExtensionEventObserverTest, NetworkRequestsMayDelaySuspend) {
   EXPECT_TRUE(test_api_->MaybeRunSuspendReadinessCallback());
   EXPECT_EQ(
       0,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 
   // Test that network requests started while a push message is pending delay
   // the suspend even after the push message has been acked.
@@ -276,18 +276,18 @@ TEST_F(ExtensionEventObserverTest, NetworkRequestsMayDelaySuspend) {
   EXPECT_TRUE(test_api_->MaybeRunSuspendReadinessCallback());
   EXPECT_EQ(
       1,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 
   extension_event_observer_->OnNetworkRequestStarted(host, kNetworkRequestId);
   extension_event_observer_->OnBackgroundEventAcked(host, kPushMessageId);
   EXPECT_EQ(
       1,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 
   extension_event_observer_->OnNetworkRequestDone(host, kNetworkRequestId);
   EXPECT_EQ(
       0,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 }
 
 // Tests that any outstanding push messages or network requests for an
@@ -320,7 +320,7 @@ TEST_F(ExtensionEventObserverTest, DeletedExtensionHostDoesNotBlockSuspend) {
   EXPECT_TRUE(test_api_->MaybeRunSuspendReadinessCallback());
   EXPECT_EQ(
       0,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 }
 
 // Tests that the ExtensionEventObserver does not delay suspend attempts when it
@@ -341,20 +341,20 @@ TEST_F(ExtensionEventObserverTest, DoesNotDelaySuspendWhenDisabled) {
       power_manager::SuspendImminent_Reason_OTHER);
   EXPECT_EQ(
       1,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 
   extension_event_observer_->SetShouldDelaySuspend(false);
   EXPECT_FALSE(test_api_->MaybeRunSuspendReadinessCallback());
   EXPECT_EQ(
       0,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 
   // Test that the ExtensionEventObserver does not delay suspend attempts when
   // it is disabled.
   FakePowerManagerClient::Get()->SendDarkSuspendImminent();
   EXPECT_EQ(
       0,
-      FakePowerManagerClient::Get()->GetNumPendingSuspendReadinessCallbacks());
+      FakePowerManagerClient::Get()->num_pending_suspend_readiness_callbacks());
 }
 
 }  // namespace chromeos

chromeos/dbus/power/fake_power_manager_client.cc

@@ -255,10 +255,6 @@ base::Closure FakePowerManagerClient::GetSuspendReadinessCallback(
                     base::Unretained(this));
 }
 
-int FakePowerManagerClient::GetNumPendingSuspendReadinessCallbacks() {
-  return num_pending_suspend_readiness_callbacks_;
-}
-
 void FakePowerManagerClient::CreateArcTimers(
     const std::string& tag,
     std::vector<std::pair<clockid_t, base::ScopedFD>> arc_timer_requests,

chromeos/dbus/power/fake_power_manager_client.h

@@ -48,6 +48,9 @@ class COMPONENT_EXPORT(CHROMEOS_DBUS) FakePowerManagerClient
   int num_wake_notification_calls() const {
     return num_wake_notification_calls_;
   }
+  int num_pending_suspend_readiness_callbacks() const {
+    return num_pending_suspend_readiness_callbacks_;
+  }
   double screen_brightness_percent() const {
     return screen_brightness_percent_.value();
   }
@@ -109,7 +112,6 @@ class COMPONENT_EXPORT(CHROMEOS_DBUS) FakePowerManagerClient
       override;
   base::Closure GetSuspendReadinessCallback(
       const base::Location& from_where) override;
-  int GetNumPendingSuspendReadinessCallbacks() override;
   void CreateArcTimers(
       const std::string& tag,
       std::vector<std::pair<clockid_t, base::ScopedFD>> arc_timer_requests,

chromeos/dbus/power/power_manager_client.cc

@@ -463,10 +463,6 @@ class PowerManagerClientImpl : public PowerManagerClient {
                       suspending_from_dark_resume_, callback_id);
   }
 
-  int GetNumPendingSuspendReadinessCallbacks() override {
-    return pending_suspend_readiness_callbacks_.size();
-  }
-
   void CreateArcTimers(
       const std::string& tag,
       std::vector<std::pair<clockid_t, base::ScopedFD>> arc_timer_requests,
@@ -1054,7 +1050,7 @@ class PowerManagerClientImpl : public PowerManagerClient {
     if (notifying_observers_about_suspend_imminent_)
       return;
 
-    if (GetNumPendingSuspendReadinessCallbacks() > 0)
+    if (!pending_suspend_readiness_callbacks_.empty())
       return;
 
     std::string method_name;

chromeos/dbus/power/power_manager_client.h

@@ -279,10 +279,6 @@ class COMPONENT_EXPORT(CHROMEOS_DBUS) PowerManagerClient {
   virtual base::Closure GetSuspendReadinessCallback(
       const base::Location& from_where) = 0;
 
-  // Returns the number of callbacks returned by GetSuspendReadinessCallback()
-  // for the current suspend attempt but not yet called. Used by tests.
-  virtual int GetNumPendingSuspendReadinessCallbacks() = 0;
-
   // Creates timers corresponding to clocks present in |arc_timer_requests|.
   // ScopedFDs are used to indicate timer expiration as described in
   // |StartArcTimer|. Aysnchronously runs |callback| with the created timers'

chromeos/disks/suspend_unmount_manager_unittest.cc

@@ -91,7 +91,7 @@ TEST_F(SuspendUnmountManagerTest, Basic) {
   fake_power_client_.SendSuspendImminent(
       power_manager::SuspendImminent_Reason_OTHER);
 
-  EXPECT_EQ(1, fake_power_client_.GetNumPendingSuspendReadinessCallbacks());
+  EXPECT_EQ(1, fake_power_client_.num_pending_suspend_readiness_callbacks());
   EXPECT_EQ(2u, disk_mount_manager_.unmounting_mount_paths().size());
   EXPECT_EQ(1, std::count(disk_mount_manager_.unmounting_mount_paths().begin(),
                           disk_mount_manager_.unmounting_mount_paths().end(),
@@ -103,7 +103,7 @@ TEST_F(SuspendUnmountManagerTest, Basic) {
                           disk_mount_manager_.unmounting_mount_paths().end(),
                           kDummyMountPathUnknown));
   disk_mount_manager_.NotifyUnmountDeviceComplete(MOUNT_ERROR_NONE);
-  EXPECT_EQ(0, fake_power_client_.GetNumPendingSuspendReadinessCallbacks());
+  EXPECT_EQ(0, fake_power_client_.num_pending_suspend_readiness_callbacks());
 }
 
 TEST_F(SuspendUnmountManagerTest, CancelAndSuspendAgain) {
@@ -119,7 +119,7 @@ TEST_F(SuspendUnmountManagerTest, CancelAndSuspendAgain) {
   disk_mount_manager_.SetupDefaultReplies();
   fake_power_client_.SendSuspendImminent(
       power_manager::SuspendImminent_Reason_OTHER);
-  EXPECT_EQ(1, fake_power_client_.GetNumPendingSuspendReadinessCallbacks());
+  EXPECT_EQ(1, fake_power_client_.num_pending_suspend_readiness_callbacks());
   ASSERT_EQ(1u, disk_mount_manager_.unmounting_mount_paths().size());
   EXPECT_EQ(kDummyMountPath,
             disk_mount_manager_.unmounting_mount_paths().front());

chromeos/system/dark_resume_controller_unittest.cc

@@ -96,7 +96,8 @@ TEST_F(DarkResumeControllerTest, CheckSuspendAfterDarkResumeNoWakeLocksHeld) {
   run_loop.RunUntilIdle();
   EXPECT_TRUE(dark_resume_controller_->IsDarkResumeStateClearedForTesting());
   EXPECT_EQ(
-      0, fake_power_manager_client()->GetNumPendingSuspendReadinessCallbacks());
+      0,
+      fake_power_manager_client()->num_pending_suspend_readiness_callbacks());
 
   // Trigger a dark resume event, acquire and release a wake lock and move time
   // forward to trigger a wake lock check. The device should re-suspend in this
@@ -110,7 +111,8 @@ TEST_F(DarkResumeControllerTest, CheckSuspendAfterDarkResumeNoWakeLocksHeld) {
   run_loop2.RunUntilIdle();
   EXPECT_TRUE(dark_resume_controller_->IsDarkResumeStateClearedForTesting());
   EXPECT_EQ(
-      0, fake_power_manager_client()->GetNumPendingSuspendReadinessCallbacks());
+      0,
+      fake_power_manager_client()->num_pending_suspend_readiness_callbacks());
 }
 
 TEST_F(DarkResumeControllerTest, CheckSuspendAfterDarkResumeWakeLocksHeld) {
@@ -136,7 +138,8 @@ TEST_F(DarkResumeControllerTest, CheckSuspendAfterDarkResumeWakeLocksHeld) {
   run_loop2.RunUntilIdle();
   EXPECT_TRUE(dark_resume_controller_->IsDarkResumeStateClearedForTesting());
   EXPECT_EQ(
-      0, fake_power_manager_client()->GetNumPendingSuspendReadinessCallbacks());
+      0,
+      fake_power_manager_client()->num_pending_suspend_readiness_callbacks());
 }
 
 TEST_F(DarkResumeControllerTest, CheckSuspendAfterDarkResumeHardTimeout) {
@@ -162,7 +165,8 @@ TEST_F(DarkResumeControllerTest, CheckSuspendAfterDarkResumeHardTimeout) {
   run_loop2.RunUntilIdle();
   EXPECT_TRUE(dark_resume_controller_->IsDarkResumeStateClearedForTesting());
   EXPECT_EQ(
-      0, fake_power_manager_client()->GetNumPendingSuspendReadinessCallbacks());
+      0,
+      fake_power_manager_client()->num_pending_suspend_readiness_callbacks());
 }
 
 TEST_F(DarkResumeControllerTest, CheckStateResetAfterSuspendDone) {

components/arc/power/arc_power_bridge_unittest.cc

@@ -128,12 +128,12 @@ TEST_F(ArcPowerBridgeTest, SuspendAndResume) {
   EXPECT_EQ(1, power_instance_->num_suspend());
   EXPECT_EQ(0, power_instance_->num_resume());
   EXPECT_EQ(1,
-            power_manager_client()->GetNumPendingSuspendReadinessCallbacks());
+            power_manager_client()->num_pending_suspend_readiness_callbacks());
 
   // Simulate Android acknowledging that it's ready for the system to suspend.
   power_instance_->GetSuspendCallback().Run();
   EXPECT_EQ(0,
-            power_manager_client()->GetNumPendingSuspendReadinessCallbacks());
+            power_manager_client()->num_pending_suspend_readiness_callbacks());
 
   power_manager_client()->SendSuspendDone();
   EXPECT_EQ(1, power_instance_->num_suspend());
@@ -144,7 +144,7 @@ TEST_F(ArcPowerBridgeTest, SuspendAndResume) {
   power_manager_client()->SendSuspendImminent(
       power_manager::SuspendImminent_Reason_OTHER);
   EXPECT_EQ(0,
-            power_manager_client()->GetNumPendingSuspendReadinessCallbacks());
+            power_manager_client()->num_pending_suspend_readiness_callbacks());
   power_manager_client()->SendSuspendDone();
 }