Commit 6873421b authored by alexmos's avatar alexmos Committed by Commit bot

Add crash keys to debug causes of a crash in RenderFrameImpl::CreateFrame

BUG=626802

Review-Url: https://codereview.chromium.org/2280473002
Cr-Commit-Position: refs/heads/master@{#414868}
parent 2f4c6f2c
...@@ -70,6 +70,16 @@ size_t RegisterEngineCrashKeys() { ...@@ -70,6 +70,16 @@ size_t RegisterEngineCrashKeys() {
{ "initrf_root_process_is_live", crash_keys::kSmallSize}, { "initrf_root_process_is_live", crash_keys::kSmallSize},
{ "initrf_root_proxy_is_live", crash_keys::kSmallSize}, { "initrf_root_proxy_is_live", crash_keys::kSmallSize},
// Temporary for https://crbug.com/626802.
{ "newframe_routing_id", crash_keys::kSmallSize },
{ "newframe_proxy_id", crash_keys::kSmallSize },
{ "newframe_opener_id", crash_keys::kSmallSize },
{ "newframe_parent_id", crash_keys::kSmallSize },
{ "newframe_widget_id", crash_keys::kSmallSize },
{ "newframe_widget_hidden", crash_keys::kSmallSize },
{ "newframe_replicated_origin", crash_keys::kSmallSize },
{ "newframe_oopifs_possible", crash_keys::kSmallSize },
// Temporary for https://crbug.com/630103. // Temporary for https://crbug.com/630103.
{ "origin_mismatch_url", crash_keys::kLargeSize }, { "origin_mismatch_url", crash_keys::kLargeSize },
{ "origin_mismatch_origin", crash_keys::kMediumSize }, { "origin_mismatch_origin", crash_keys::kMediumSize },
......
...@@ -138,6 +138,16 @@ size_t RegisterCrashKeysHelper() { ...@@ -138,6 +138,16 @@ size_t RegisterCrashKeysHelper() {
{"initrf_root_process_is_live", kSmallSize}, {"initrf_root_process_is_live", kSmallSize},
{"initrf_root_proxy_is_live", kSmallSize}, {"initrf_root_proxy_is_live", kSmallSize},
// Temporary for https://crbug.com/626802.
{ "newframe_routing_id", kSmallSize },
{ "newframe_proxy_id", kSmallSize },
{ "newframe_opener_id", kSmallSize },
{ "newframe_parent_id", kSmallSize },
{ "newframe_widget_id", kSmallSize },
{ "newframe_widget_hidden", kSmallSize },
{ "newframe_replicated_origin", kSmallSize },
{ "newframe_oopifs_possible", kSmallSize },
// Temporary for https://crbug.com/630103. // Temporary for https://crbug.com/630103.
{ "origin_mismatch_url", crash_keys::kLargeSize }, { "origin_mismatch_url", crash_keys::kLargeSize },
{ "origin_mismatch_origin", crash_keys::kMediumSize }, { "origin_mismatch_origin", crash_keys::kMediumSize },
......
...@@ -193,6 +193,16 @@ size_t RegisterChromeCrashKeys() { ...@@ -193,6 +193,16 @@ size_t RegisterChromeCrashKeys() {
{ "initrf_root_process_is_live", kSmallSize}, { "initrf_root_process_is_live", kSmallSize},
{ "initrf_root_proxy_is_live", kSmallSize}, { "initrf_root_proxy_is_live", kSmallSize},
// Temporary for https://crbug.com/626802.
{ "newframe_routing_id", kSmallSize },
{ "newframe_proxy_id", kSmallSize },
{ "newframe_opener_id", kSmallSize },
{ "newframe_parent_id", kSmallSize },
{ "newframe_widget_id", kSmallSize },
{ "newframe_widget_hidden", kSmallSize },
{ "newframe_replicated_origin", kSmallSize },
{ "newframe_oopifs_possible", kSmallSize },
// Temporary for https://crbug.com/630103. // Temporary for https://crbug.com/630103.
{ "origin_mismatch_url", crash_keys::kLargeSize }, { "origin_mismatch_url", crash_keys::kLargeSize },
{ "origin_mismatch_origin", crash_keys::kMediumSize }, { "origin_mismatch_origin", crash_keys::kMediumSize },
......
...@@ -73,6 +73,7 @@ ...@@ -73,6 +73,7 @@
#include "content/common/render_process_messages.h" #include "content/common/render_process_messages.h"
#include "content/common/resource_messages.h" #include "content/common/resource_messages.h"
#include "content/common/service_worker/embedded_worker_setup.mojom.h" #include "content/common/service_worker/embedded_worker_setup.mojom.h"
#include "content/common/site_isolation_policy.h"
#include "content/common/view_messages.h" #include "content/common/view_messages.h"
#include "content/common/worker_messages.h" #include "content/common/worker_messages.h"
#include "content/public/common/content_constants.h" #include "content/public/common/content_constants.h"
...@@ -1688,6 +1689,24 @@ void RenderThreadImpl::OnProcessPurgeAndSuspend() { ...@@ -1688,6 +1689,24 @@ void RenderThreadImpl::OnProcessPurgeAndSuspend() {
} }
void RenderThreadImpl::OnCreateNewFrame(FrameMsg_NewFrame_Params params) { void RenderThreadImpl::OnCreateNewFrame(FrameMsg_NewFrame_Params params) {
// Debug cases of https://crbug.com/626802.
base::debug::SetCrashKeyValue("newframe_routing_id",
base::IntToString(params.routing_id));
base::debug::SetCrashKeyValue("newframe_proxy_id",
base::IntToString(params.proxy_routing_id));
base::debug::SetCrashKeyValue("newframe_opener_id",
base::IntToString(params.opener_routing_id));
base::debug::SetCrashKeyValue("newframe_parent_id",
base::IntToString(params.parent_routing_id));
base::debug::SetCrashKeyValue("newframe_widget_id",
base::IntToString(
params.widget_params.routing_id));
base::debug::SetCrashKeyValue("newframe_widget_hidden",
params.widget_params.hidden ? "yes" : "no");
base::debug::SetCrashKeyValue("newframe_replicated_origin",
params.replication_state.origin.Serialize());
base::debug::SetCrashKeyValue("newframe_oopifs_possible",
SiteIsolationPolicy::AreCrossProcessFramesPossible() ? "yes" : "no");
CompositorDependencies* compositor_deps = this; CompositorDependencies* compositor_deps = this;
RenderFrameImpl::CreateFrame( RenderFrameImpl::CreateFrame(
params.routing_id, params.proxy_routing_id, params.opener_routing_id, params.routing_id, params.proxy_routing_id, params.opener_routing_id,
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment