dpwas: Rename mayChangeRunOnOsLoginMode to mayShowRunOnOsLoginMode

As we look towards adding a enterprise policy, we want to have an
option to show/hide the menu item, and an option to enabled/disabled
the menu item.

This CL updates the existing parameter to indicate what the flag
actually does.

Explainer: https://github.com/MicrosoftEdge/MSEdgeExplainers/blob/master/RunOnLogin/Explainer.md
I2P: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/T6d2zqF_jpw/76TP7Bc2DwAJ

Bug: 897302
Change-Id: I4ef7becd32dd003d8efaab503f0d51a7919d589a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2637329Reviewed-by: Evan Stade <estade@chromium.org>
Reviewed-by: Daniel Murphy <dmurph@chromium.org>
Reviewed-by: Chase Phillips <cmp@chromium.org>
Commit-Queue: Mike Jackson <mjackson@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#845290}

chrome/browser/resources/ntp4/apps_page.js

@@ -201,11 +201,9 @@ cr.define('ntp', function() {
       this.installLocallySeparator_.hidden = this.installLocally_.hidden =
           app.appData.isLocallyInstalled;
 
-      this.runOnOsLogin_.hidden = !app.appData.mayChangeRunOnOsLoginMode;
-      if (app.appData.mayChangeRunOnOsLoginMode) {
-        this.runOnOsLogin_.checked =
-            app.appData.runOnOsLoginMode != RUN_ON_OS_LOGIN_MODE.NONE;
-      }
+      this.runOnOsLogin_.hidden = !app.appData.mayShowRunOnOsLoginMode;
+      this.runOnOsLogin_.checked =
+          app.appData.runOnOsLoginMode != RUN_ON_OS_LOGIN_MODE.NONE;
     },
 
     /** @private */

chrome/browser/resources/ntp4/page_list_view.js

@@ -33,7 +33,7 @@
  *            launch_container: number,
  *            launch_type: number,
  *            mayChangeLaunchType: boolean,
- *            mayChangeRunOnOsLoginMode: boolean,
+ *            mayShowRunOnOsLoginMode: boolean,
  *            mayCreateShortcuts: boolean,
  *            mayDisable: boolean,
  *            name: string,

chrome/browser/ui/webui/ntp/app_launcher_handler.cc

@@ -281,7 +281,7 @@ void AppLauncherHandler::CreateWebAppInfo(const web_app::AppId& app_id,
 
   // Run on OS Login can be changed only for locally installed web apps
   value->SetBoolean(
-      "mayChangeRunOnOsLoginMode",
+      "mayShowRunOnOsLoginMode",
       base::FeatureList::IsEnabled(features::kDesktopPWAsRunOnOsLogin) &&
           is_locally_installed);
   std::string runOnOsLoginModeString =
@@ -400,7 +400,7 @@ void AppLauncherHandler::CreateExtensionInfo(const Extension* extension,
   value->SetString("app_launch_ordinal", app_launch_ordinal.ToInternalValue());
 
   // Run on OS Login is not implemented for extension/bookmark apps.
-  value->SetBoolean("mayChangeRunOnOsLoginMode", false);
+  value->SetBoolean("mayShowRunOnOsLoginMode", false);
 }
 
 // static