Reland "Simplify in-process URLRequestContext creation with the NetworkService."
This reverts commit d6870941. Reason for revert: The original CL wasn't the cause of the mac bots failing. Original change's description: > Revert "Simplify in-process URLRequestContext creation with the NetworkService." > > This reverts commit f34bba7c. > > Reason for revert: A lot of tests are failing on Mac10.10 and Mac10.12. > Looking at both blame[1][2] lists when the tests started failing, this > seems like the most likely culprit. > > [1] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.10%20Tests/33158 > [2] https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/13801 > > Original change's description: > > Simplify in-process URLRequestContext creation with the NetworkService. > > > > The old code hooked up things to the URLRequestContext that hadn't been > > ported over to work with the NetworkService yet, when the NetworkService > > was enabled. This CL just does the minimum setup that's needed to not > > crash. It also makes requests made with the in-process URLRequestContext > > fail when the network service is enabled. These changes will help > > identify code that still depends on the legacy path, and allow for some > > cleanup of URLRequestContextBuilderMojo and NetworkContext. > > > > Cq-Include-Trybots: luci.chromium.try:linux_mojo > > Change-Id: I4c3f40e6dc3c235844846bff7d1d43d0b1c986d0 > > Bug: 825242 > > Reviewed-on: https://chromium-review.googlesource.com/1096075 > > Commit-Queue: Matt Menke <mmenke@chromium.org> > > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#567879} > > TBR=jam@chromium.org,mmenke@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 825242 > Change-Id: I36da9fb06fa89296e031c88d7c75c16e63f3b725 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Reviewed-on: https://chromium-review.googlesource.com/1103818 > Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org> > Cr-Commit-Position: refs/heads/master@{#567932} TBR=jam@chromium.org,mmenke@chromium.org,ortuno@chromium.org Change-Id: I4f379142535672553027802c10d0a678a5734aad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 825242 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1103858Reviewed-by:Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#567948}
Showing
This diff is collapsed.
This diff is collapsed.
Please register or sign in to comment