[Tab] Remove deprecated onReparentingFinished.

Removes the deprecated onReparentingFinished in favor of the new method
onActivityAttachmentChanged.

Updates callers of the old method.

Bug: 
Change-Id: I67920b1caea804281972fbac32f91cd4509c281f
Reviewed-on: https://chromium-review.googlesource.com/775733Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Yusuf Ozuysal <yusufo@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517523}

chrome/android/java/src/org/chromium/chrome/browser/infobar/InfoBarContainer.java

@@ -127,13 +127,14 @@ public class InfoBarContainer extends SwipableOverlayView {
         }
 
         @Override
-        public void onReparentingFinished(Tab tab) {
+        public void onActivityAttachmentChanged(Tab tab, boolean isAttached) {
+            if (!isAttached) return;
+
             setParentView((ViewGroup) tab.getActivity().findViewById(R.id.bottom_container));
             mTab = tab;
         }
     };
 
-
     /**
      * Adds/removes the {@link InfoBarContainer} when the tab's view is attached/detached. This is
      * mostly to ensure the infobars are not shown in tab switcher overview mode.

chrome/android/java/src/org/chromium/chrome/browser/media/PictureInPictureController.java

@@ -295,7 +295,7 @@ public class PictureInPictureController {
     /**
      * A class to dismiss the Activity when the tab:
      * - Closes.
-     * - Reparents.
+     * - Reparents: Attaches to a different activity.
      * - Crashes.
      * - Leaves fullscreen.
      */
@@ -306,8 +306,10 @@ public class PictureInPictureController {
         }
 
         @Override
-        public void onReparentingFinished(Tab tab) {
-            dismissActivity(mActivity, METRICS_END_REASON_REPARENT);
+        public void onActivityAttachmentChanged(Tab tab, boolean isAttached) {
+            if (isAttached) {
+                dismissActivity(mActivity, METRICS_END_REASON_REPARENT);
+            }
         }
 
         @Override

chrome/android/java/src/org/chromium/chrome/browser/tab/EmptyTabObserver.java

@@ -115,9 +115,6 @@ public class EmptyTabObserver implements TabObserver {
             long openerRenderProcessId, long openerRenderFrameId, String frameName,
             String targetUrl, WebContents newWebContents) {}
 
-    @Override
-    public void onReparentingFinished(Tab tab) {}
-
     @Override
     public void onActivityAttachmentChanged(Tab tab, boolean isAttached) {}
 

chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

@@ -1531,10 +1531,6 @@ public class Tab
         mIsTabStateDirty = true;
 
         if (finalizeCallback != null) finalizeCallback.run();
-
-        for (TabObserver observer : mObservers) {
-            observer.onReparentingFinished(this);
-        }
     }
 
     /**

chrome/android/java/src/org/chromium/chrome/browser/tab/TabObserver.java

@@ -292,14 +292,6 @@ public interface TabObserver {
      */
     public void onActivityAttachmentChanged(Tab tab, boolean isAttached);
 
-    /**
-     * Called when the tab reparenting process has finished.
-     * Deprecated, use {@link #onActivityAttachmentChanged(Tab, boolean)} instead.
-     * @param tab The notifying {@link Tab}.
-     */
-    @Deprecated
-    public void onReparentingFinished(Tab tab);
-
     /**
      * A notification when tab changes whether or not it is interactable and is accepting input.
      * @param isInteractable Whether or not the tab is interactable.