Commit 69501bf0 authored by dpapad's avatar dpapad Committed by Commit Bot

Polymer: Fix minify_polymer.py to work with recent shell=False changes.

The change at r782918, which modified RunNode() to use shell=False,
broke this script, and started returning incorrect output (JS
comments were not stripped)

Bug: 1096473
Change-Id: I9d767d0ec2d92612ddf73c37e8ab70c4aedc6573
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2284015
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
Commit-Queue: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#785833}
parent e3e29b38
......@@ -55,7 +55,7 @@ def main():
extracted_js = os.path.join(tmp_out_dir, 'polymer-extracted.js')
node.RunNode([
node_modules.PathToUglify(), extracted_js,
'--comments', '"/Copyright|license|LICENSE/"',
'--comments', '/Copyright|license|LICENSE/',
'--output', extracted_js])
# Copy generated bundled JS/HTML files back to the original location.
......
......@@ -53,7 +53,7 @@ def main():
node.RunNode([
node_modules.PathToUglify(), bundled_js,
# TODO(dpapad): Figure out a way to deduplicate LICENSE headers.
#'--comments', '"/Copyright|license|LICENSE/"',
#'--comments', '/Copyright|license|LICENSE/',
'--output', minified_js])
# Copy generated JS bundle back to the original location.
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment