Commit 695b06d1 authored by Giovanni Ortuño Urquidi's avatar Giovanni Ortuño Urquidi Committed by Commit Bot

Revert "Improved error reporting when execvp fails"

This reverts commit 7e47f6d4.

Reason for revert: Possible culprit of failures on Linux Tests (dbg)(1) 

First failing build: https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/b8870138525564824400

All failing tests have the following lines:
LaunchProcess: failed to execvp:
xdg-desktop-menu
No such file or directory
LaunchProcess: failed to execvp:
xdg-icon-resource


Original change's description:
> Improved error reporting when execvp fails
> 
> Currently the execvp fails for a launch process it does not give
> much diagnosis. This change reports the errno reason why the execvp
> failed. This has been useful in finding simple naming errors.
> 
> Change-Id: Ifcc33c87931535019d8509234818c9d995fa4b9d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2383292
> Commit-Queue: Peter McNeeley <petermcneeley@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#804383}

TBR=penghuang@chromium.org,dcheng@chromium.org,rsesek@chromium.org,fangzhoug@chromium.org,petermcneeley@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I1b39de8b004e4318560c8a304043057d040f2e13
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397476Reviewed-by: default avatarGiovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#804858}
parent 35ee38bc
......@@ -35,7 +35,6 @@
#include "base/logging.h"
#include "base/metrics/histogram_macros.h"
#include "base/posix/eintr_wrapper.h"
#include "base/posix/safe_strerror.h"
#include "base/process/environment_internal.h"
#include "base/process/process.h"
#include "base/process/process_metrics.h"
......@@ -486,9 +485,6 @@ Process LaunchProcess(const std::vector<std::string>& argv,
RAW_LOG(ERROR, "LaunchProcess: failed to execvp:");
RAW_LOG(ERROR, argv_cstr[0]);
char error_buff[256] = {};
base::safe_strerror_r(errno, error_buff, sizeof(error_buff));
RAW_LOG(ERROR, error_buff);
_exit(127);
} else {
// Parent process
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment