Commit 696227bb authored by Claude van der Merwe's avatar Claude van der Merwe Committed by Commit Bot

Add Phone Hub feature item summaries

Add Phone Hub, Phone Hub Notifications, Phone Hub Notifications
Badge and Phone Hub Task continuation feature item summaries to
Multi Device sub page.

Bug: 1106937
Change-Id: Ib1b99e6d1187220eceb365e97b1177c15f1cad24
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386420Reviewed-by: default avatarKyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Claude van der Merwe <cvandermerwe@google.com>
Cr-Commit-Position: refs/heads/master@{#803467}
parent cef37fcd
......@@ -2206,6 +2206,18 @@
<message name="IDS_SETTINGS_MULTIDEVICE_PHONE_HUB_TASK_CONTINUATION_SECTION_TITLE" translateable="false" desc="The title of the Phone Hub Task Continuation section on the settings page.">
Task Continuation
</message>
<message name="IDS_SETTINGS_MULTIDEVICE_PHONE_HUB_SUMMARY" translateable="false" desc="Description of for the 'Phone Hub' setting. This feature lets the user stay productive on Chrome OS by ensuring that their phones' apps, content, and connectivity are available on their Chrome OS device.">
Make the best of your Android phone on your your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
</message>
<message name="IDS_SETTINGS_MULTIDEVICE_PHONE_HUB_NOTIFICATIONS_SUMMARY" translateable="false" desc="Description of for the 'Phone Hub Notifications' setting. This feature mirrors notifications from a connected Android phone to Chrome OS devices.">
View your phones notifications on your <ph name="DEVICE_TYPE">$1<ex>Chromebook</ex></ph>
</message>
<message name="IDS_SETTINGS_MULTIDEVICE_PHONE_HUB_NOTIFICATION_BADGE_SUMMARY" translateable="false" desc="Description of for the 'Phone Hub Notification Badge' setting. This feature shows an indicator in the Chrome OS shelf when notifications are mirrored from a connected Android phone.">
Indicator in shelf when new notifications come in
</message>
<message name="IDS_SETTINGS_MULTIDEVICE_PHONE_HUB_TASK_CONTINUATION_SUMMARY" translateable="false" desc="Description of for the 'Phone Hub Task Continuation' setting. This feature lets users resume in-app actions and chrome tabs that are open on a connected Android phone from Chrome OS devices.">
View your active Chrome tabs in Phone Hub
</message>
<message name="IDS_SETTINGS_MULTIDEVICE_NOTIFICATION_ACCESS_SETUP_DIALOG_ACK_TITLE" translateable="false" desc="The title of the dialog containing the Phone Hub notification opt-in flow shown when the Phone Hub 'Notifications' toggle is switched on.">
Turn on notifications on Android phone
</message>
......
......@@ -158,6 +158,16 @@ const MultiDeviceFeatureBehaviorImpl = {
return this.i18nAdvanced('multideviceInstantTetheringItemSummary');
case settings.MultiDeviceFeature.MESSAGES:
return this.i18nAdvanced('multideviceAndroidMessagesItemSummary');
case settings.MultiDeviceFeature.PHONE_HUB:
return this.i18nAdvanced('multidevicePhoneHubItemSummary');
case settings.MultiDeviceFeature.PHONE_HUB_NOTIFICATIONS:
return this.i18nAdvanced('multidevicePhoneHubNotificationsItemSummary');
case settings.MultiDeviceFeature.PHONE_HUB_NOTIFICATION_BADGE:
return this.i18nAdvanced(
'multidevicePhoneHubNotificationBadgeItemSummary');
case settings.MultiDeviceFeature.PHONE_HUB_TASK_CONTINUATION:
return this.i18nAdvanced(
'multidevicePhoneHubTaskContinuationItemSummary');
default:
return '';
}
......
......@@ -253,6 +253,10 @@ void MultiDeviceSection::AddLoadTimeData(
IDS_SETTINGS_MULTIDEVICE_PHONE_HUB_NOTIFICATION_BADGE_SECTION_TITLE},
{"multidevicePhoneHubTaskContinuationItemTitle",
IDS_SETTINGS_MULTIDEVICE_PHONE_HUB_TASK_CONTINUATION_SECTION_TITLE},
{"multidevicePhoneHubNotificationBadgeItemSummary",
IDS_SETTINGS_MULTIDEVICE_PHONE_HUB_NOTIFICATION_BADGE_SUMMARY},
{"multidevicePhoneHubTaskContinuationItemSummary",
IDS_SETTINGS_MULTIDEVICE_PHONE_HUB_TASK_CONTINUATION_SUMMARY},
{"multideviceNotificationAccessSetupAckTitle",
IDS_SETTINGS_MULTIDEVICE_NOTIFICATION_ACCESS_SETUP_DIALOG_ACK_TITLE},
{"multideviceNotificationAccessSetupConnectingTitle",
......@@ -328,6 +332,15 @@ void MultiDeviceSection::AddLoadTimeData(
IDS_SETTINGS_MULTIDEVICE_SMART_LOCK_SUMMARY,
ui::GetChromeOSDeviceName(),
GetHelpUrlWithBoard(chrome::kEasyUnlockLearnMoreUrl)));
html_source->AddString(
"multidevicePhoneHubItemSummary",
l10n_util::GetStringFUTF16(IDS_SETTINGS_MULTIDEVICE_PHONE_HUB_SUMMARY,
ui::GetChromeOSDeviceName()));
html_source->AddString(
"multidevicePhoneHubNotificationsItemSummary",
l10n_util::GetStringFUTF16(
IDS_SETTINGS_MULTIDEVICE_PHONE_HUB_NOTIFICATIONS_SUMMARY,
ui::GetChromeOSDeviceName()));
AddEasyUnlockStrings(html_source);
::settings::AddNearbyShareData(html_source);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment