Commit 69a4d500 authored by Lei Zhang's avatar Lei Zhang Committed by Commit Bot

Print Preview; Replace cr.isWin with cr.isWindows.

cr.isWin() does not exist. Also fix formatting for some TODO entries.

Change-Id: Ib64b2eeac0166484e60bf93c5a60159def81afec
Reviewed-on: https://chromium-review.googlesource.com/1204590Reviewed-by: default avatarRebekah Potter <rbpotter@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588895}
parent 0b22a424
...@@ -44,7 +44,7 @@ Polymer({ ...@@ -44,7 +44,7 @@ Polymer({
.ADVANCED_SETTINGS_DIALOG_SHOWN); .ADVANCED_SETTINGS_DIALOG_SHOWN);
// This async() call is a workaround to prevent a DCHECK - see // This async() call is a workaround to prevent a DCHECK - see
// https://crbug.com/804047. // https://crbug.com/804047.
// TODO (rbpotter): Remove after Polymer2 migration is complete. // TODO(rbpotter): Remove after Polymer2 migration is complete.
this.async(() => { this.async(() => {
this.$.dialog.showModal(); this.$.dialog.showModal();
}, 1); }, 1);
......
...@@ -268,7 +268,7 @@ Polymer({ ...@@ -268,7 +268,7 @@ Polymer({
// Don't try to print with system dialog on Windows if the document is // Don't try to print with system dialog on Windows if the document is
// not ready, because we send the preview document to the printer on // not ready, because we send the preview document to the printer on
// Windows. // Windows.
if (!cr.isWin || this.state == print_preview_new.State.READY) if (!cr.isWindows || this.state == print_preview_new.State.READY)
this.onPrintWithSystemDialog_(); this.onPrintWithSystemDialog_();
e.preventDefault(); e.preventDefault();
return; return;
...@@ -305,7 +305,7 @@ Polymer({ ...@@ -305,7 +305,7 @@ Polymer({
onCrDialogClose_: function(e) { onCrDialogClose_: function(e) {
// Note: due to event re-firing in cr_dialog.js, this event will always // Note: due to event re-firing in cr_dialog.js, this event will always
// appear to be coming from the outermost child dialog. // appear to be coming from the outermost child dialog.
// TODO (rbpotter): Fix event re-firing so that the event comes from the // TODO(rbpotter): Fix event re-firing so that the event comes from the
// dialog that has been closed, and add an assertion that the removed // dialog that has been closed, and add an assertion that the removed
// dialog matches e.composedPath()[0]. // dialog matches e.composedPath()[0].
if (e.composedPath()[0].nodeName == 'CR-DIALOG') if (e.composedPath()[0].nodeName == 'CR-DIALOG')
......
...@@ -89,7 +89,7 @@ Polymer({ ...@@ -89,7 +89,7 @@ Polymer({
const dialog = this.$.destinationDialog.get(); const dialog = this.$.destinationDialog.get();
// This async() call is a workaround to prevent a DCHECK - see // This async() call is a workaround to prevent a DCHECK - see
// https://crbug.com/804047. // https://crbug.com/804047.
// TODO (rbpotter): Remove after Polymer2 migration is complete. // TODO(rbpotter): Remove after Polymer2 migration is complete.
this.async(() => { this.async(() => {
dialog.show(); dialog.show();
}, 1); }, 1);
......
...@@ -755,7 +755,7 @@ Polymer({ ...@@ -755,7 +755,7 @@ Polymer({
} }
if (destination.isPrivet || destination.isExtension) { if (destination.isPrivet || destination.isExtension) {
// TODO (rbpotter): Get local and PDF printers to use the same ticket and // TODO(rbpotter): Get local and PDF printers to use the same ticket and
// send only this ticket instead of nesting it in a larger ticket. // send only this ticket instead of nesting it in a larger ticket.
ticket.ticket = this.createCloudJobTicket(destination); ticket.ticket = this.createCloudJobTicket(destination);
ticket.capabilities = JSON.stringify(destination.capabilities); ticket.capabilities = JSON.stringify(destination.capabilities);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment