Commit 69d1b3b8 authored by rouslan@chromium.org's avatar rouslan@chromium.org

Include upstream libaddressinput strings in Chrome build.

This patch adds the upstream libaddressinput strings into the Chrome
build inside of chrome/app/address_input.grd[p] to work well with the
translation tools.

This patch should precede using upstream libaddressinput to ensure that
the upstream libaddressinput has the correct strings well ahead of using
it in Chrome.

Although the strings include postal code examples and links for error
messages, these features are optional and can be turned off if
undesired.

BUG=327046

Review URL: https://codereview.chromium.org/304223010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276559 0039d316-1c4b-4281-b951-d872f2087c98
parent e4be6e2d
...@@ -39,7 +39,7 @@ vars = { ...@@ -39,7 +39,7 @@ vars = {
# to update other nacl_*_revision's. # to update other nacl_*_revision's.
"nacl_tools_revision": "13077", # native_client/DEPS: tools_rev "nacl_tools_revision": "13077", # native_client/DEPS: tools_rev
"google_toolbox_for_mac_revision": "662", "google_toolbox_for_mac_revision": "662",
"libaddressinput_revision": "265", "libaddressinput_revision": "273",
"libphonenumber_revision": "621", "libphonenumber_revision": "621",
"libvpx_revision": "269083", "libvpx_revision": "269083",
"lss_revision": "26", "lss_revision": "26",
......
This diff is collapsed.
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="am">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="ar">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="bg">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="bn">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="ca">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="cs">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="da">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="de">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="el">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="en-GB">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="es-419">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="es">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="et">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="fa">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="fi">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="fil">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="fr">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="gu">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="hi">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="hr">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="hu">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="id">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="it">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="iw">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="ja">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="kn">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="ko">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="lt">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="lv">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="ml">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="mr">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="ms">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="nl">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="no">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="pl">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="pt-BR">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="pt-PT">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="ro">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="ru">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="sk">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="sl">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="sr">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="sv">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="sw">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="ta">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="te">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="th">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="tr">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="uk">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="vi">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="zh-CN">
</translationbundle>
<?xml version="1.0" ?>
<!DOCTYPE translationbundle>
<translationbundle lang="zh-TW">
</translationbundle>
...@@ -115,6 +115,11 @@ def calc_inputs(locale): ...@@ -115,6 +115,11 @@ def calc_inputs(locale):
inputs.append(os.path.join(SHARE_INT_DIR, 'third_party', 'libaddressinput', inputs.append(os.path.join(SHARE_INT_DIR, 'third_party', 'libaddressinput',
'libaddressinput_strings_%s.pak' % locale)) 'libaddressinput_strings_%s.pak' % locale))
#e.g. '<(SHARED_INTERMEDIATE_DIR)/grit/libaddressinput/
# address_input_strings_da.pak',
inputs.append(os.path.join(SHARE_INT_DIR, 'grit', 'libaddressinput',
'address_input_strings_%s.pak' % locale))
#e.g. '<(grit_out_dir)/google_chrome_strings_da.pak' #e.g. '<(grit_out_dir)/google_chrome_strings_da.pak'
# or # or
# '<(grit_out_dir)/chromium_strings_da.pak' # '<(grit_out_dir)/chromium_strings_da.pak'
......
...@@ -2,8 +2,8 @@ Name: The library to input, validate, and display addresses. ...@@ -2,8 +2,8 @@ Name: The library to input, validate, and display addresses.
Short Name: libaddressinput Short Name: libaddressinput
URL: https://code.google.com/p/libaddressinput/ URL: https://code.google.com/p/libaddressinput/
Version: 0 Version: 0
Date: 4 June 2014 Date: 10 June 2014
Revision: 265 Revision: 273
License: Apache 2.0 License: Apache 2.0
License File: LICENSE License File: LICENSE
Security Critical: no Security Critical: no
......
...@@ -24,14 +24,6 @@ to the upstream library at https://libaddressinput.googlecode.com/. ...@@ -24,14 +24,6 @@ to the upstream library at https://libaddressinput.googlecode.com/.
script_dir = os.path.dirname(os.path.realpath(__file__)) script_dir = os.path.dirname(os.path.realpath(__file__))
from_file = os.path.abspath(os.path.join( from_file = os.path.abspath(os.path.join(
script_dir, os.pardir, os.pardir, 'src', 'cpp', 'res', 'messages.grdp')) script_dir, os.pardir, os.pardir, 'src', 'cpp', 'res', 'messages.grdp'))
if not os.path.isfile(from_file):
# Android and iOS do not use src/third_party/libaddressinput/src/. Gclient
# cannot filter out hooks based on OS or (when using git) based on file name
# patterns.
print('No libaddressinput for this target OS.')
sys.exit()
to_file = os.path.abspath(os.path.join( to_file = os.path.abspath(os.path.join(
script_dir, os.pardir, os.pardir, os.pardir, os.pardir, 'chrome', 'app', script_dir, os.pardir, os.pardir, os.pardir, os.pardir, 'chrome', 'app',
'address_input_strings.grdp')) 'address_input_strings.grdp'))
......
...@@ -41,6 +41,27 @@ ...@@ -41,6 +41,27 @@
'../../build/grit_target.gypi', '../../build/grit_target.gypi',
], ],
}, },
{
'target_name': 'libaddressinput_updated_strings',
'type': 'none',
'variables': {
'grit_out_dir': '<(SHARED_INTERMEDIATE_DIR)/grit/libaddressinput/',
},
'actions': [
{
'action_name': 'libaddressinput_updated_strings',
'variables': {
'grit_grd_file': '../../chrome/app/address_input_strings.grd',
},
'includes': [
'../../build/grit_action.gypi',
],
},
],
'includes': [
'../../build/grit_target.gypi',
],
},
# This target provides basic functionality which is cooked into the build. # This target provides basic functionality which is cooked into the build.
{ 'target_name': 'libaddressinput_util', { 'target_name': 'libaddressinput_util',
'type': 'static_library', 'type': 'static_library',
...@@ -129,6 +150,7 @@ ...@@ -129,6 +150,7 @@
], ],
'dependencies': [ 'dependencies': [
'libaddressinput_strings', 'libaddressinput_strings',
'libaddressinput_updated_strings',
'libaddressinput_util', 'libaddressinput_util',
'<(DEPTH)/base/base.gyp:base', '<(DEPTH)/base/base.gyp:base',
'<(DEPTH)/base/base.gyp:base_i18n', '<(DEPTH)/base/base.gyp:base_i18n',
......
...@@ -201,6 +201,9 @@ ...@@ -201,6 +201,9 @@
"third_party/libaddressinput/chromium/cpp/res/libaddressinput_strings.grd": { "third_party/libaddressinput/chromium/cpp/res/libaddressinput_strings.grd": {
"messages": [29050], "messages": [29050],
}, },
"chrome/app/address_input_strings.grd": {
"messages": [29100],
},
"components/components_strings.grd": { "components/components_strings.grd": {
"messages": [30000], "messages": [30000],
}, },
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment