Commit 69e95cc2 authored by Caroline Rising's avatar Caroline Rising Committed by Commit Bot

Disable tab hover cards for mac on TOT and set default group to Enabled C.

Bug: 1017821
Change-Id: I39fc6148524086fb45437911580a98d896263600
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879694Reviewed-by: default avatarAlexei Svitkine <asvitkine@chromium.org>
Reviewed-by: default avatarPeter Boström <pbos@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#709156}
parent 5581dc00
......@@ -65,8 +65,15 @@ const base::Feature kTabGroups{"TabGroups", base::FEATURE_DISABLED_BY_DEFAULT};
// Enables popup cards containing tab information when hovering over a tab.
// https://crbug.com/910739
const base::Feature kTabHoverCards{"TabHoverCards",
base::FEATURE_ENABLED_BY_DEFAULT};
const base::Feature kTabHoverCards {
"TabHoverCards",
#if defined(OS_MACOSX)
base::FEATURE_DISABLED_BY_DEFAULT
#else
base::FEATURE_ENABLED_BY_DEFAULT
#endif // defined(OS_MACOSX)
};
// Parameter name used for tab hover cards user study.
// TODO(corising): Removed this after tab hover cards user study.
const char kTabHoverCardsFeatureParameterName[] = "setting";
......
......@@ -71,7 +71,7 @@ bool AreHoverCardImagesEnabled() {
base::TimeDelta GetMinimumTriggerDelay() {
int delay_group = base::GetFieldTrialParamByFeatureAsInt(
features::kTabHoverCards, features::kTabHoverCardsFeatureParameterName,
0);
2);
switch (delay_group) {
case 2:
return base::TimeDelta::FromMilliseconds(150);
......@@ -86,7 +86,7 @@ base::TimeDelta GetMinimumTriggerDelay() {
base::TimeDelta GetMaximumTriggerDelay() {
int delay_group = base::GetFieldTrialParamByFeatureAsInt(
features::kTabHoverCards, features::kTabHoverCardsFeatureParameterName,
0);
2);
switch (delay_group) {
case 2:
return base::TimeDelta::FromMilliseconds(500);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment