[fuchsia] Update Fuchsia-related TODOs with bug references

Bug: 1104411
Change-Id: I3752f13c65f326a56ae40fc4823aca0bc7fa1537
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425119
Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#812435}

base/debug/stack_trace_fuchsia.cc

@@ -120,9 +120,10 @@ void SymbolMap::Populate() {
 
   // Try to fetch the name of the process' main executable, which was set as the
   // name of the |process| kernel object.
-  // TODO(wez): Object names can only have up to ZX_MAX_NAME_LEN characters, so
-  // if we keep hitting problems with truncation, find a way to plumb argv[0]
-  // through to here instead, e.g. using CommandLine::GetProgramName().
+  // TODO(crbug.com/1131250): Object names can only have up to ZX_MAX_NAME_LEN
+  // characters, so if we keep hitting problems with truncation, find a way to
+  // plumb argv[0] through to here instead, e.g. using
+  // CommandLine::GetProgramName().
   char app_name[std::extent<decltype(SymbolMap::Module::name)>()];
   zx_status_t status =
       zx_object_get_property(process, ZX_PROP_NAME, app_name, sizeof(app_name));

base/process/kill_fuchsia.cc

@@ -34,8 +34,8 @@ TerminationStatus GetTerminationStatus(ProcessHandle handle, int* exit_code) {
     return TERMINATION_STATUS_STILL_RUNNING;
   }
 
-  // TODO(fuchsia): Is there more information about types of crashes, OOM, etc.
-  // available? https://crbug.com/706592.
+  // TODO(crbug.com/1133865): Is there more information about types of crashes,
+  // OOM, etc. available?
 
   *exit_code = process_info.return_code;
   return process_info.return_code == 0

base/process/process_fuchsia.cc

@@ -254,8 +254,8 @@ bool Process::IsProcessBackgrounded() const {
 }
 
 bool Process::SetProcessBackgrounded(bool value) {
-  // No process priorities on Fuchsia. TODO(fuchsia): See MG-783, and update
-  // this later if priorities are implemented.
+  // No process priorities on Fuchsia.
+  // TODO(fxbug.dev/30735): Update this later if priorities are implemented.
   return false;
 }
 

base/process/process_iterator_fuchsia.cc

@@ -8,19 +8,17 @@
 namespace base {
 
 ProcessIterator::ProcessIterator(const ProcessFilter* filter) {
-  // TODO(fuchsia): There's no Fuchsia API to iterate processes currently.
+  // TODO(crbug.com/1131239): Implement ProcessIterator on Fuchsia.
   NOTREACHED();
 }
 
 ProcessIterator::~ProcessIterator() {}
 
 bool ProcessIterator::CheckForNextProcess() {
-  // TODO(fuchsia): There's no Fuchsia API to iterate processes currently.
   return false;
 }
 
 bool NamedProcessIterator::IncludeEntry() {
-  // TODO(fuchsia): There's no Fuchsia API to iterate processes currently.
   return false;
 }
 

chromecast/fuchsia/queryable_data_host_fuchsia.cc

@@ -15,7 +15,8 @@ QueryableDataHostFuchsia::~QueryableDataHostFuchsia() {}
 
 void QueryableDataHostFuchsia::SendQueryableValue(const std::string& key,
                                                   const base::Value& value) {
-  // TODO(elvin): async call to update queryable values when runner fidl exists
+  // TODO(b/169167391): async call to update queryable values when runner fidl
+  // exists.
   LOG(ERROR) << "Not Implemented: SendQueryableValue" << key << " " << value;
 }
 

chromecast/media/cma/backend/fuchsia/mixer_output_stream_fuchsia.cc

@@ -32,8 +32,6 @@ constexpr base::TimeDelta kTargetWritePeriod =
 constexpr int kMaxOutputBufferSizeFrames = 4096;
 
 // Current AudioRenderer implementation allows only one buffer with id=0.
-// TODO(sergeyu): Replace with an incrementing buffer id once AddPayloadBuffer()
-// and RemovePayloadBuffer() are implemented properly in AudioRenderer.
 const uint32_t kBufferId = 0;
 
 // static
@@ -159,7 +157,6 @@ bool MixerOutputStreamFuchsia::Write(const float* data,
     // Block the thread to limit amount of buffered data. Currently
     // MixerOutputStreamAlsa uses blocking Write() and StreamMixer relies on
     // that behavior. Sleep() below replicates the same behavior on Fuchsia.
-    // TODO(sergeyu): Refactor StreamMixer to work with non-blocking Write().
     base::TimeDelta max_buffer_duration =
         ::media::AudioTimestampHelper::FramesToTime(kMaxOutputBufferSizeFrames,
                                                     sample_rate_);

fuchsia/http/http_service_impl.cc

@@ -8,7 +8,8 @@
 #include "net/url_request/url_request_context_builder.h"
 
 HttpServiceImpl::HttpServiceImpl() {
-  // TODO: Set the right options in the URLRequestContextBuilder.
+  // TODO(crbug.com/1131111): Set the right options in the
+  // URLRequestContextBuilder.
 }
 
 HttpServiceImpl::~HttpServiceImpl() = default;

media/audio/fuchsia/audio_output_stream_fuchsia.cc

@@ -18,8 +18,9 @@
 namespace media {
 
 // Current AudioRenderer implementation allows only one buffer with id=0.
-// TODO(sergeyu): Replace with an incrementing buffer id once AddPayloadBuffer()
-// and RemovePayloadBuffer() are implemented properly in AudioRenderer.
+// TODO(crbug.com/1131179): Replace with an incrementing buffer id now that
+// AddPayloadBuffer() and RemovePayloadBuffer() are implemented properly in
+// AudioRenderer.
 const uint32_t kBufferId = 0;
 
 AudioOutputStreamFuchsia::AudioOutputStreamFuchsia(

media/filters/fuchsia/fuchsia_video_decoder.cc

@@ -265,7 +265,7 @@ class FuchsiaVideoDecoder : public VideoDecoder,
 
   VideoCodec current_codec_ = kUnknownVideoCodec;
 
-  // TODO(sergeyu): Use StreamProcessorHelper.
+  // TODO(crbug.com/1131175): Use StreamProcessorHelper.
   fuchsia::media::StreamProcessorPtr decoder_;
 
   base::Optional<fuchsia::media::StreamBufferConstraints>

media/fuchsia/audio/fuchsia_audio_renderer.cc

@@ -239,8 +239,8 @@ void FuchsiaAudioRenderer::SetVolume(float volume) {
 
 void FuchsiaAudioRenderer::SetLatencyHint(
     base::Optional<base::TimeDelta> latency_hint) {
-  // TODO(chcunningham): Implement at some later date after we've vetted the API
-  // shape and usefulness outside of fuchsia.
+  // TODO(crbug.com/1131116): Implement at some later date after we've vetted
+  // the API shape and usefulness outside of fuchsia.
 }
 
 void FuchsiaAudioRenderer::SetPreservesPitch(bool preserves_pitch) {}

media/fuchsia/cdm/fuchsia_cdm.cc

@@ -319,7 +319,7 @@ void FuchsiaCdm::CreateSessionAndGenerateRequest(
     EmeInitDataType init_data_type,
     const std::vector<uint8_t>& init_data,
     std::unique_ptr<NewSessionCdmPromise> promise) {
-  // TODO(yucliu): Support persistent license.
+  // TODO(crbug.com/1131114): Support persistent license.
   if (session_type != CdmSessionType::kTemporary) {
     promise->reject(CdmPromise::Exception::NOT_SUPPORTED_ERROR, 0,
                     "session type is not supported.");

media/fuchsia/common/sysmem_buffer_pool.h

@@ -106,8 +106,8 @@ class BufferAllocator {
   std::unique_ptr<SysmemBufferPool::Creator> MakeBufferPoolCreatorFromToken(
       fuchsia::sysmem::BufferCollectionTokenPtr token);
 
-  // TODO(sergeyu): Update FuchsiaVideoDecoder to use SysmemBufferPool and
-  // remove this function.
+  // TODO(crbug.com/1131183): Update FuchsiaVideoDecoder to use SysmemBufferPool
+  // and remove this function.
   fuchsia::sysmem::Allocator* raw() { return allocator_.get(); }
 
  private:

mojo/core/channel_fuchsia.cc

@@ -358,8 +358,8 @@ class ChannelFuchsia : public Channel,
         outgoing_handle.CompleteTransit();
 
       if (result != ZX_OK) {
-        // TODO(fuchsia): Handle ZX_ERR_SHOULD_WAIT flow-control errors, once
-        // the platform starts generating them. See https://crbug.com/754084.
+        // TODO(crbug.com/754084): Handle ZX_ERR_SHOULD_WAIT flow-control
+        // errors, once the platform starts generating them.
         ZX_DLOG_IF(ERROR, result != ZX_ERR_PEER_CLOSED, result)
             << "WriteNoLock(zx_channel_write)";
         return false;
@@ -379,8 +379,8 @@ class ChannelFuchsia : public Channel,
       // reading to fetch any in-flight messages, relying on end-of-stream to
       // signal the actual disconnection.
       if (read_watch_) {
-        // TODO: When we add flow-control for writes, we also need to reset the
-        // write-watcher here.
+        // TODO(crbug.com/754084): When we add flow-control for writes, we also
+        // need to reset the write-watcher here.
         return;
       }
     }

net/base/network_interfaces_fuchsia.cc

@@ -34,8 +34,8 @@ using ConnectionType = NetworkChangeNotifier::ConnectionType;
 NetworkInterface NetworkInterfaceFromAddress(
     const fuchsia::netstack::NetInterface& interface,
     size_t address_index) {
-  // TODO(sergeyu): attributes field is used to return address state for IPv6
-  // addresses. Currently Netstack doesn't provide this information.
+  // TODO(crbug.com/1131220): attributes field is used to return address state
+  // for IPv6 addresses. Currently Netstack doesn't provide this information.
   const int attributes = 0;
 
   IPAddress address;
@@ -111,7 +111,8 @@ bool GetNetworkList(NetworkInterfaceList* networks, int policy) {
   fuchsia::netstack::NetstackSyncPtr netstack;
   base::ComponentContextForProcess()->svc()->Connect(netstack.NewRequest());
 
-  // TODO(kmarshall): Use NetworkChangeNotifier's cached interface list.
+  // TODO(crbug.com/1131238): Use NetworkChangeNotifier's cached interface
+  // list.
   std::vector<fuchsia::netstack::NetInterface> interfaces;
   zx_status_t status = netstack->GetInterfaces(&interfaces);
   if (status != ZX_OK) {

services/resource_coordinator/public/cpp/memory_instrumentation/os_metrics_fuchsia.cc

@@ -44,7 +44,7 @@ bool OSMetrics::FillOSMemoryDump(base::ProcessId pid,
 // static
 std::vector<mojom::VmRegionPtr> OSMetrics::GetProcessMemoryMaps(
     base::ProcessId) {
-  // TODO(fuchsia): Implement this. See crbug.com/750948
+  // TODO(crbug.com/750948): Implement this.
   NOTIMPLEMENTED();
   return std::vector<mojom::VmRegionPtr>();
 }

ui/base/idle/idle_fuchsia.cc

@@ -9,13 +9,13 @@
 namespace ui {
 
 int CalculateIdleTime() {
-  // TODO(fuchsia): https://crbug.com/743296.
+  // TODO(crbug.com/1133867): Implement this.
   NOTIMPLEMENTED();
   return 0;
 }
 
 bool CheckIdleStateIsLocked() {
-  // TODO(fuchsia): https://crbug.com/743296.
+  // TODO(crbug.com/1133867): Implement this.
   NOTIMPLEMENTED();
   return false;
 }

ui/shell_dialogs/select_file_dialog_fuchsia.cc

@@ -11,7 +11,6 @@ namespace ui {
 SelectFileDialog* CreateSelectFileDialog(
     SelectFileDialog::Listener* listener,
     std::unique_ptr<SelectFilePolicy> policy) {
-  // TODO(fuchsia): Port once we have UI, see https://crbug.com/746674.
   NOTREACHED();
   return nullptr;
 }