Commit 6a1a354c authored by Nigel Tao's avatar Nigel Tao Committed by Commit Bot

Have Skia use Wuffs v0.3 not v0.2

Skia-uses-Wuffs is still disabled by default in Chromium, but when
enabled, it now uses a newer Wuffs version, the same as upstream Skia.

New in Wuffs v0.3 is a finer sub-division of the base module, but the
main reason to upgrade is to track upstream Skia.

Change-Id: I5d0e152d45cccc24389a8091f93728047742943a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2256918Reviewed-by: default avatarLeon Scroggins <scroggo@google.com>
Reviewed-by: default avatarJohn Abd-El-Malek <jam@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#782163}
parent 24e74947
...@@ -40,10 +40,12 @@ buildflag_header("buildflags") { ...@@ -40,10 +40,12 @@ buildflag_header("buildflags") {
# External-facing config for dependent code. # External-facing config for dependent code.
config("skia_config") { config("skia_config") {
defines = []
include_dirs = [ "//third_party/skia" ] include_dirs = [ "//third_party/skia" ]
if (!is_ios) { if (!is_ios) {
if (enable_skia_wuffs_gif) { if (enable_skia_wuffs_gif) {
defines += [ "SK_FAVOR_WUFFS_V_0_3_OVER_V_0_2" ]
include_dirs += [ "//third_party/wuffs/src/release/c" ] include_dirs += [ "//third_party/wuffs/src/release/c" ]
} else { } else {
include_dirs += [ "//third_party/libgifcodec" ] include_dirs += [ "//third_party/libgifcodec" ]
...@@ -54,7 +56,7 @@ config("skia_config") { ...@@ -54,7 +56,7 @@ config("skia_config") {
configs = [ "//third_party/vulkan_headers:vulkan_headers_config" ] configs = [ "//third_party/vulkan_headers:vulkan_headers_config" ]
} }
defines = [ defines += [
"SK_CODEC_DECODES_PNG", "SK_CODEC_DECODES_PNG",
"SK_CODEC_DECODES_WEBP", "SK_CODEC_DECODES_WEBP",
"SK_ENCODE_PNG", "SK_ENCODE_PNG",
......
...@@ -64,7 +64,9 @@ static_library("wuffs") { ...@@ -64,7 +64,9 @@ static_library("wuffs") {
# Do not modify this list without considering the "consult # Do not modify this list without considering the "consult
# ENG_REVIEW_OWNERS" comment at the top of this file. # ENG_REVIEW_OWNERS" comment at the top of this file.
"WUFFS_CONFIG__MODULES", "WUFFS_CONFIG__MODULES",
"WUFFS_CONFIG__MODULE__BASE", "WUFFS_CONFIG__MODULE__BASE__CORE",
"WUFFS_CONFIG__MODULE__BASE__INTERFACES",
"WUFFS_CONFIG__MODULE__BASE__PIXCONV",
"WUFFS_CONFIG__MODULE__GIF", "WUFFS_CONFIG__MODULE__GIF",
"WUFFS_CONFIG__MODULE__LZW", "WUFFS_CONFIG__MODULE__LZW",
] ]
...@@ -73,7 +75,7 @@ static_library("wuffs") { ...@@ -73,7 +75,7 @@ static_library("wuffs") {
# comment at the top of this file. # comment at the top of this file.
visibility = [ "//skia" ] visibility = [ "//skia" ]
sources = [ "src/release/c/wuffs-v0.2.c" ] sources = [ "src/release/c/wuffs-v0.3.c" ]
} }
# Do not add build targets, or change their configuration or visibility, # Do not add build targets, or change their configuration or visibility,
# without considering the "consult ENG_REVIEW_OWNERS" comment at the top of # without considering the "consult ENG_REVIEW_OWNERS" comment at the top of
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment