Make the GPU feature info code more compact.
AddExtensionString is called quite a lot, always with a constant string literal, which makes it a bit unnecessary to convert the argument to a std::string before every function call. This small change cuts away 7 KB of the machine code: Total change: -7208 bytes ========================= 1 added, totalling +559 bytes across 1 sources 1 removed, totalling -471 bytes across 1 sources 1 shrunk, for a net change of -7296 bytes (25422 bytes before, 18126 bytes after) across 1 sources 267984 unchanged, totalling 50299073 bytes Per-source Analysis: -------------------------------------------------------------------------------------------------------------------- -7208 - Source: /home/bratell/src/chromium/src/gpu/command_buffer/service/feature_info.cc - (gained 559, lost 7767) -------------------------------------------------------------------------------------------------------------------- New symbols: +559: gpu::gles2::FeatureInfo::AddExtensionString(char const*) type=t, size=559 bytes Removed symbols: -471: gpu::gles2::FeatureInfo::AddExtensionString(std::string const&) type=t, size=471 bytes Shrunk symbols: -7296: gpu::gles2::FeatureInfo::InitializeFeatures() type=t, (was 25422 bytes, now 18126 bytes) BUG= Review URL: https://codereview.chromium.org/571073003 Cr-Commit-Position: refs/heads/master@{#296785}
Showing
Please register or sign in to comment