Commit 6a77bdd8 authored by Ben Kelly's avatar Ben Kelly Committed by Commit Bot

CacheStorage: Disable parallel reads on android.

The parallel read experiment shows that cache match miss rate regresses
on android for some reason.  All other platforms show big progressions.
Therefore we are going to keep parallel reads disabled on just android
while enabling it by default for all other platforms.

Bug: 985379
Change-Id: I05c24f94f4ce2fe5246f2811ed605adf094412f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1825398Reviewed-by: default avatarMatt Falkenhagen <falken@chromium.org>
Commit-Queue: Ben Kelly <wanderview@chromium.org>
Cr-Commit-Position: refs/heads/master@{#700008}
parent 965a4d98
...@@ -13,6 +13,7 @@ ...@@ -13,6 +13,7 @@
#include "base/metrics/field_trial_params.h" #include "base/metrics/field_trial_params.h"
#include "base/metrics/histogram_macros.h" #include "base/metrics/histogram_macros.h"
#include "base/sequenced_task_runner.h" #include "base/sequenced_task_runner.h"
#include "build/build_config.h"
#include "content/browser/cache_storage/cache_storage_histogram_utils.h" #include "content/browser/cache_storage/cache_storage_histogram_utils.h"
#include "content/browser/cache_storage/cache_storage_operation.h" #include "content/browser/cache_storage/cache_storage_operation.h"
#include "content/public/common/content_features.h" #include "content/public/common/content_features.h"
...@@ -24,8 +25,17 @@ namespace { ...@@ -24,8 +25,17 @@ namespace {
// Maximum parallel shared operations. This constant was selected via // Maximum parallel shared operations. This constant was selected via
// experimentation. We tried 4, 16, and 64 for the limit. 16 was clearly // experimentation. We tried 4, 16, and 64 for the limit. 16 was clearly
// better than 4, but 64 was did not provide significant further benefit. // better than 4, but 64 was did not provide significant further benefit.
// TODO(crbug/1007994): Enable parallel shared operations on android after
// performance regressions are addressed.
#if defined(OS_ANDROID)
constexpr int kDefaultMaxSharedOps = 1;
#else
constexpr int kDefaultMaxSharedOps = 16;
#endif
const base::FeatureParam<int> kCacheStorageMaxSharedOps{ const base::FeatureParam<int> kCacheStorageMaxSharedOps{
&features::kCacheStorageParallelOps, "max_shared_ops", 16}; &features::kCacheStorageParallelOps, "max_shared_ops",
kDefaultMaxSharedOps};
} // namespace } // namespace
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment