Commit 6a856e64 authored by David Schinazi's avatar David Schinazi Committed by Chromium LUCI CQ

Add more details to QuicConnectionCloseFrame netlog

This CL adds all information from connection close
frames to netlog to facilitate debugging.

R=renjietang@chromium.org

Change-Id: Ia158f2e711aa455e30a790e80e1739b5707fc346
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575696
Commit-Queue: David Schinazi <dschinazi@chromium.org>
Commit-Queue: Renjie Tang <renjietang@chromium.org>
Auto-Submit: David Schinazi <dschinazi@chromium.org>
Reviewed-by: default avatarRenjie Tang <renjietang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#833948}
parent ba5053b8
...@@ -174,6 +174,26 @@ base::Value NetLogQuicConnectionCloseFrameParams( ...@@ -174,6 +174,26 @@ base::Value NetLogQuicConnectionCloseFrameParams(
const quic::QuicConnectionCloseFrame* frame) { const quic::QuicConnectionCloseFrame* frame) {
base::Value dict(base::Value::Type::DICTIONARY); base::Value dict(base::Value::Type::DICTIONARY);
dict.SetIntKey("quic_error", frame->quic_error_code); dict.SetIntKey("quic_error", frame->quic_error_code);
if (frame->wire_error_code != frame->quic_error_code) {
dict.SetIntKey("quic_wire_error", frame->wire_error_code);
}
std::string close_type;
switch (frame->close_type) {
case quic::GOOGLE_QUIC_CONNECTION_CLOSE:
close_type = "gQUIC";
break;
case quic::IETF_QUIC_TRANSPORT_CONNECTION_CLOSE:
close_type = "Transport";
break;
case quic::IETF_QUIC_APPLICATION_CONNECTION_CLOSE:
close_type = "Application";
break;
}
dict.SetStringKey("close_type", close_type);
if (frame->transport_close_frame_type != 0) {
dict.SetKey("transport_close_frame_type",
NetLogNumberValue(frame->transport_close_frame_type));
}
dict.SetStringKey("details", frame->error_details); dict.SetStringKey("details", frame->error_details);
return dict; return dict;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment