Convert FrameMsg_SetNeedsOcclusionTracking to blink mojom RemoteFrame

BUG=104106
R=dcheng@chromium.org, dtapuska@chromium.org, haraken@chromium.org

Change-Id: Ib778b3cdb059dd5079f3b9e7ec61af1bb5107cdb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2002750Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Antonio Gomes <tonikitoo@igalia.com>
Cr-Commit-Position: refs/heads/master@{#732342}

content/browser/frame_host/render_frame_host_impl.cc

@@ -3540,8 +3540,7 @@ void RenderFrameHostImpl::SetNeedsOcclusionTracking(bool needs_tracking) {
     return;
   }
 
-  proxy->Send(new FrameMsg_SetNeedsOcclusionTracking(proxy->GetRoutingID(),
-                                                     needs_tracking));
+  proxy->GetAssociatedRemoteFrame()->SetNeedsOcclusionTracking(needs_tracking);
 }
 
 void RenderFrameHostImpl::LifecycleStateChanged(

content/common/frame_messages.h

@@ -838,11 +838,6 @@ IPC_MESSAGE_ROUTED2(FrameMsg_SetPepperVolume,
                     double /* volume */)
 #endif  // BUILDFLAG(ENABLE_PLUGINS)
 
-// Notifies a parent frame that the child frame requires information about
-// whether it is occluded or has visual effects applied.
-IPC_MESSAGE_ROUTED1(FrameMsg_SetNeedsOcclusionTracking,
-                    bool /* needs_tracking */)
-
 // Tells the frame to update the user activation state in appropriate part of
 // the frame tree (ancestors for activation notification and all nodes for
 // consumption).

content/renderer/render_frame_proxy.cc

@@ -423,8 +423,6 @@ bool RenderFrameProxy::OnMessageReceived(const IPC::Message& msg) {
                         OnDidSetFramePolicyHeaders)
     IPC_MESSAGE_HANDLER(FrameMsg_ForwardResourceTimingToParent,
                         OnForwardResourceTimingToParent)
-    IPC_MESSAGE_HANDLER(FrameMsg_SetNeedsOcclusionTracking,
-                        OnSetNeedsOcclusionTracking)
     IPC_MESSAGE_HANDLER(FrameMsg_DidUpdateName, OnDidUpdateName)
     IPC_MESSAGE_HANDLER(FrameMsg_EnforceInsecureRequestPolicy,
                         OnEnforceInsecureRequestPolicy)
@@ -499,10 +497,6 @@ void RenderFrameProxy::OnForwardResourceTimingToParent(
       ResourceTimingInfoToWebResourceTimingInfo(info));
 }
 
-void RenderFrameProxy::OnSetNeedsOcclusionTracking(bool needs_tracking) {
-  web_frame_->SetNeedsOcclusionTracking(needs_tracking);
-}
-
 void RenderFrameProxy::OnDidUpdateName(const std::string& name,
                                        const std::string& unique_name) {
   web_frame_->SetReplicatedName(blink::WebString::FromUTF8(name));

content/renderer/render_frame_proxy.h

@@ -238,7 +238,6 @@ class CONTENT_EXPORT RenderFrameProxy : public IPC::Listener,
       blink::ParsedFeaturePolicy parsed_feature_policy);
   void OnForwardResourceTimingToParent(
       const ResourceTimingInfo& resource_timing);
-  void OnSetNeedsOcclusionTracking(bool);
   void OnDidUpdateName(const std::string& name, const std::string& unique_name);
   void OnEnforceInsecureRequestPolicy(blink::WebInsecureRequestPolicy policy);
   void OnSetFrameOwnerProperties(const FrameOwnerProperties& properties);

third_party/blink/public/mojom/frame/frame.mojom

@@ -255,6 +255,11 @@ interface RemoteFrame {
   // (eg. the iframe, portal, or object element).
   DispatchLoadEventForFrameOwner();
 
+  // Sent to the remote frame placeholder in the parent process to indicate the
+  // associated frame in the child process requires information about
+  // whether it is occluded or has visual effects applied.
+  SetNeedsOcclusionTracking(bool needs_tracking);
+
   // Sent to the process that owns this frame's HTMLFrameOwnerElement to
   // control whether the element is collapsed or not. If the element is
   // collapsed, it will be removed from the layout tree of its parent

third_party/blink/public/web/web_remote_frame.h

@@ -128,8 +128,6 @@ class WebRemoteFrame : public WebFrame {
   // Reports resource timing info for a navigation in this frame.
   virtual void ForwardResourceTimingToParent(const WebResourceTimingInfo&) = 0;
 
-  virtual void SetNeedsOcclusionTracking(bool) = 0;
-
   virtual void DidStartLoading() = 0;
   virtual void DidStopLoading() = 0;
 

third_party/blink/renderer/core/exported/web_remote_frame_impl.cc

@@ -319,10 +319,6 @@ void WebRemoteFrameImpl::ForwardResourceTimingToParent(
                           mojo::NullReceiver() /* worker_timing_receiver */);
 }
 
-void WebRemoteFrameImpl::SetNeedsOcclusionTracking(bool needs_tracking) {
-  GetFrame()->View()->SetNeedsOcclusionTracking(needs_tracking);
-}
-
 void WebRemoteFrameImpl::DidStartLoading() {
   GetFrame()->SetIsLoading(true);
 }

third_party/blink/renderer/core/exported/web_remote_frame_impl.h

@@ -91,7 +91,6 @@ class CORE_EXPORT WebRemoteFrameImpl final
   void SetReplicatedInsecureRequestPolicy(WebInsecureRequestPolicy) override;
   void SetReplicatedInsecureNavigationsSet(const WebVector<unsigned>&) override;
   void ForwardResourceTimingToParent(const WebResourceTimingInfo&) override;
-  void SetNeedsOcclusionTracking(bool) override;
   void DidStartLoading() override;
   void DidStopLoading() override;
   bool IsIgnoredForHitTest() const override;

third_party/blink/renderer/core/frame/remote_frame.cc

@@ -361,6 +361,10 @@ void RemoteFrame::SetHadStickyUserActivationBeforeNavigation(bool value) {
   Frame::SetHadStickyUserActivationBeforeNavigation(value);
 }
 
+void RemoteFrame::SetNeedsOcclusionTracking(bool needs_tracking) {
+  View()->SetNeedsOcclusionTracking(needs_tracking);
+}
+
 void RemoteFrame::BubbleLogicalScroll(
     mojom::blink::ScrollDirection direction,
     ui::input_types::ScrollGranularity granularity) {

third_party/blink/renderer/core/frame/remote_frame.h

@@ -103,6 +103,7 @@ class CORE_EXPORT RemoteFrame final : public Frame,
   void Collapse(bool collapsed) final;
   void Focus() override;
   void SetHadStickyUserActivationBeforeNavigation(bool value) override;
+  void SetNeedsOcclusionTracking(bool needs_tracking) override;
   void BubbleLogicalScroll(
       mojom::blink::ScrollDirection direction,
       ui::input_types::ScrollGranularity granularity) override;