Commit 6a9c17d1 authored by Victor Costan's avatar Victor Costan Committed by Chromium LUCI CQ

WebSQL: Remove OriginInfo::DBInfo::last_modified.

The member is written, but never read.

Change-Id: I401c9e2b3c443ad1e31730a2862a485bfb4fd570
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634863
Commit-Queue: Victor Costan <pwnall@chromium.org>
Reviewed-by: default avatarJoshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#844915}
parent 03509fc0
...@@ -67,14 +67,6 @@ int64_t OriginInfo::GetDatabaseSize(const base::string16& database_name) const { ...@@ -67,14 +67,6 @@ int64_t OriginInfo::GetDatabaseSize(const base::string16& database_name) const {
return 0; return 0;
} }
base::Time OriginInfo::GetDatabaseLastModified(
const base::string16& database_name) const {
auto it = database_info_.find(database_name);
if (it != database_info_.end())
return it->second.last_modified;
return base::Time();
}
OriginInfo::OriginInfo(const std::string& origin_identifier, int64_t total_size) OriginInfo::OriginInfo(const std::string& origin_identifier, int64_t total_size)
: origin_identifier_(origin_identifier), total_size_(total_size) {} : origin_identifier_(origin_identifier), total_size_(total_size) {}
...@@ -594,8 +586,7 @@ DatabaseTracker::CachedOriginInfo* DatabaseTracker::MaybeGetCachedOriginInfo( ...@@ -594,8 +586,7 @@ DatabaseTracker::CachedOriginInfo* DatabaseTracker::MaybeGetCachedOriginInfo(
// TODO(jsbell): Avoid duplicate base::GetFileInfo calls between this and // TODO(jsbell): Avoid duplicate base::GetFileInfo calls between this and
// the GetDBFileSize() call above. // the GetDBFileSize() call above.
if (base::GetFileInfo(path, &file_info)) { if (base::GetFileInfo(path, &file_info)) {
origin_info.SetDatabaseLastModified(db.database_name, origin_info.UpdateLastModified(file_info.last_modified);
file_info.last_modified);
} }
} }
} }
......
...@@ -57,12 +57,10 @@ class COMPONENT_EXPORT(STORAGE_BROWSER) OriginInfo { ...@@ -57,12 +57,10 @@ class COMPONENT_EXPORT(STORAGE_BROWSER) OriginInfo {
base::Time LastModified() const { return last_modified_; } base::Time LastModified() const { return last_modified_; }
void GetAllDatabaseNames(std::vector<base::string16>* databases) const; void GetAllDatabaseNames(std::vector<base::string16>* databases) const;
int64_t GetDatabaseSize(const base::string16& database_name) const; int64_t GetDatabaseSize(const base::string16& database_name) const;
base::Time GetDatabaseLastModified(const base::string16& database_name) const;
protected: protected:
struct DBInfo { struct DBInfo {
int64_t size; int64_t size;
base::Time last_modified;
}; };
OriginInfo(const std::string& origin_identifier, int64_t total_size); OriginInfo(const std::string& origin_identifier, int64_t total_size);
...@@ -201,9 +199,7 @@ class COMPONENT_EXPORT(STORAGE_BROWSER) DatabaseTracker ...@@ -201,9 +199,7 @@ class COMPONENT_EXPORT(STORAGE_BROWSER) DatabaseTracker
if (new_size != old_size) if (new_size != old_size)
total_size_ += new_size - old_size; total_size_ += new_size - old_size;
} }
void SetDatabaseLastModified(const base::string16& database_name, void UpdateLastModified(base::Time last_modified) {
const base::Time& last_modified) {
database_info_[database_name].last_modified = last_modified;
if (last_modified > last_modified_) if (last_modified > last_modified_)
last_modified_ = last_modified; last_modified_ = last_modified;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment