Commit 6aaacd63 authored by samli@chromium.org's avatar samli@chromium.org

Devtools UI: Remove redundant tooltips

Tooltips should be used where they add value to the the user. This change removes instances where tooltips are used with the same text as is already displayed.

BUG=513066

Review URL: https://codereview.chromium.org/1262063003

git-svn-id: svn://svn.chromium.org/blink/trunk@201577 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent b89b63f6
...@@ -510,9 +510,9 @@ WebInspector.linkifyURLAsNode = function(url, linkText, classes, isExternal, too ...@@ -510,9 +510,9 @@ WebInspector.linkifyURLAsNode = function(url, linkText, classes, isExternal, too
if (href !== null) if (href !== null)
a.href = href; a.href = href;
a.className = classes; a.className = classes;
if (typeof tooltipText === "undefined") if (!tooltipText && linkText !== url)
a.title = url; a.title = url;
else if (typeof tooltipText !== "string" || tooltipText.length) else if (tooltipText)
a.title = tooltipText; a.title = tooltipText;
a.textContent = linkText.trimMiddle(WebInspector.Linkifier.MaxLengthForDisplayedURLs); a.textContent = linkText.trimMiddle(WebInspector.Linkifier.MaxLengthForDisplayedURLs);
if (isExternal) if (isExternal)
......
...@@ -54,9 +54,7 @@ WebInspector.ComputedStyleWidget = function(stylesSidebarPane, sharedModel) ...@@ -54,9 +54,7 @@ WebInspector.ComputedStyleWidget = function(stylesSidebarPane, sharedModel)
var toolbar = new WebInspector.Toolbar(hbox); var toolbar = new WebInspector.Toolbar(hbox);
toolbar.element.classList.add("styles-pane-toolbar"); toolbar.element.classList.add("styles-pane-toolbar");
toolbar.appendToolbarItem(new WebInspector.ToolbarCheckbox(WebInspector.UIString("Show inherited"), toolbar.appendToolbarItem(new WebInspector.ToolbarCheckbox(WebInspector.UIString("Show all"), undefined, this._showInheritedComputedStylePropertiesSetting));
WebInspector.UIString("Show inherited properties"),
this._showInheritedComputedStylePropertiesSetting));
this._propertiesOutline = new TreeOutlineInShadow(); this._propertiesOutline = new TreeOutlineInShadow();
this._propertiesOutline.registerRequiredCSS("elements/computedStyleSidebarPane.css"); this._propertiesOutline.registerRequiredCSS("elements/computedStyleSidebarPane.css");
......
...@@ -2223,7 +2223,6 @@ WebInspector.StylePropertyTreeElement.prototype = { ...@@ -2223,7 +2223,6 @@ WebInspector.StylePropertyTreeElement.prototype = {
this.listItemElement.removeChildren(); this.listItemElement.removeChildren();
this.nameElement = propertyRenderer.renderName(); this.nameElement = propertyRenderer.renderName();
this.nameElement.title = this.property.propertyText;
this.valueElement = propertyRenderer.renderValue(); this.valueElement = propertyRenderer.renderValue();
if (!this.treeOutline) if (!this.treeOutline)
return; return;
......
...@@ -338,8 +338,6 @@ function TreeElement(title, expandable) ...@@ -338,8 +338,6 @@ function TreeElement(title, expandable)
this._listItemNode.treeElement = this; this._listItemNode.treeElement = this;
if (title) if (title)
this.title = title; this.title = title;
if (typeof title === "string")
this.tooltip = title;
this._listItemNode.addEventListener("mousedown", this._handleMouseDown.bind(this), false); this._listItemNode.addEventListener("mousedown", this._handleMouseDown.bind(this), false);
this._listItemNode.addEventListener("selectstart", this._treeElementSelectStart.bind(this), false); this._listItemNode.addEventListener("selectstart", this._treeElementSelectStart.bind(this), false);
this._listItemNode.addEventListener("click", this._treeElementToggled.bind(this), false); this._listItemNode.addEventListener("click", this._treeElementToggled.bind(this), false);
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment