Commit 6ab736ed authored by Rohit Rao's avatar Rohit Rao Committed by Commit Bot

[ios] Fixes FullscreenTestCase.testLongPDFInitialState when UIRefresh is enabled.

This test checks for a specific contentOffset, which is different under the
UIRefresh experiment.

BUG=825431

Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ibe5e4743eb6471025fde7b27785a4267f42e0e91
Reviewed-on: https://chromium-review.googlesource.com/989250
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: default avatarKurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547492}
parent 3790ebd8
......@@ -88,11 +88,24 @@ void AssertURLIs(const GURL& expectedURL) {
[ChromeEarlGrey loadURL:URL];
[ChromeEarlGreyUI waitForToolbarVisible:YES];
// Initial y scroll position is -56 on iPhone and -95 on iPad, to make room
// for the toolbar.
// Initial y scroll positions are set to make room for the toolbar.
// TODO(crbug.com/618887) Replace use of specific values when API which
// generates these values is exposed.
CGFloat yOffset = IsIPadIdiom() ? -95.0 : -56.0;
CGFloat yOffset = 0;
if (IsUIRefreshPhase1Enabled()) {
if (IsIPadIdiom()) {
yOffset = -89.0;
} else {
yOffset = -48.0;
}
} else {
if (IsIPadIdiom()) {
yOffset = -95.0;
} else {
yOffset = -56.0;
}
}
DCHECK_LT(yOffset, 0);
[[EarlGrey
selectElementWithMatcher:web::WebViewScrollView(
chrome_test_util::GetCurrentWebState())]
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment