Commit 6abc1622 authored by Nicolas Pena's avatar Nicolas Pena Committed by Commit Bot

[LongTasks] Change TaskAttributionTiming name to 'unknown'

At TPAC, we agreed that 'script' is confusing because it implies that
longtasks only measure script work. Thus, we decided to change the name
to 'unknown'. Also see https://github.com/w3c/longtasks/issues/47.

Change-Id: I5a0666d0fa078bfeac8ab6e8397b9b51aca3e833
Reviewed-on: https://chromium-review.googlesource.com/c/1336367Reviewed-by: default avatarTimothy Dresser <tdresser@chromium.org>
Commit-Queue: Nicolás Peña Moreno <npm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608479}
parent ead8f859
...@@ -32,7 +32,7 @@ ...@@ -32,7 +32,7 @@
'Exactly one attribution entry is expected'); 'Exactly one attribution entry is expected');
const attribution = longtask.attribution[0]; const attribution = longtask.attribution[0];
assert_equals(attribution.entryType, 'taskattribution'); assert_equals(attribution.entryType, 'taskattribution');
assert_equals(attribution.name, 'script'); assert_equals(attribution.name, 'unknown');
assert_equals(attribution.duration, 0); assert_equals(attribution.duration, 0);
assert_equals(attribution.startTime, 0); assert_equals(attribution.startTime, 0);
assert_equals(attribution.containerId, ''); assert_equals(attribution.containerId, '');
...@@ -52,4 +52,4 @@ ...@@ -52,4 +52,4 @@
}, 'Performance longtask entries are observable.'); }, 'Performance longtask entries are observable.');
</script> </script>
</body> </body>
\ No newline at end of file
...@@ -33,7 +33,7 @@ ...@@ -33,7 +33,7 @@
'Exactly one attribution entry is expected'); 'Exactly one attribution entry is expected');
const attribution = longtask.attribution[0]; const attribution = longtask.attribution[0];
assert_equals(attribution.entryType, 'taskattribution'); assert_equals(attribution.entryType, 'taskattribution');
assert_equals(attribution.name, 'script'); assert_equals(attribution.name, 'unknown');
assert_equals(attribution.duration, 0); assert_equals(attribution.duration, 0);
assert_equals(attribution.startTime, 0); assert_equals(attribution.startTime, 0);
assert_equals(attribution.containerId, 'child-iframe-id'); assert_equals(attribution.containerId, 'child-iframe-id');
......
...@@ -38,7 +38,7 @@ ...@@ -38,7 +38,7 @@
'Exactly one attribution entry is expected'); 'Exactly one attribution entry is expected');
const attribution = longtask.attribution[0]; const attribution = longtask.attribution[0];
assert_equals(attribution.entryType, 'taskattribution'); assert_equals(attribution.entryType, 'taskattribution');
assert_equals(attribution.name, 'script'); assert_equals(attribution.name, 'unknown');
assert_equals(attribution.duration, 0); assert_equals(attribution.duration, 0);
assert_equals(attribution.startTime, 0); assert_equals(attribution.startTime, 0);
assert_equals(attribution.containerId, 'child-iframe-id'); assert_equals(attribution.containerId, 'child-iframe-id');
......
...@@ -29,7 +29,7 @@ ...@@ -29,7 +29,7 @@
'Exactly one attribution entry is expected'); 'Exactly one attribution entry is expected');
const attribution = longtask.attribution[0]; const attribution = longtask.attribution[0];
assert_equals(attribution.entryType, 'taskattribution'); assert_equals(attribution.entryType, 'taskattribution');
assert_equals(attribution.name, 'script'); assert_equals(attribution.name, 'unknown');
assert_equals(attribution.duration, 0); assert_equals(attribution.duration, 0);
assert_equals(attribution.startTime, 0); assert_equals(attribution.startTime, 0);
assert_equals(attribution.containerId, ''); assert_equals(attribution.containerId, '');
...@@ -47,4 +47,4 @@ ...@@ -47,4 +47,4 @@
} }
}, 'Performance longtask entries are observable.'); }, 'Performance longtask entries are observable.');
</script> </script>
</body> </body>
\ No newline at end of file
...@@ -15,7 +15,7 @@ ...@@ -15,7 +15,7 @@
window.addEventListener('message', t.step_func(e => { window.addEventListener('message', t.step_func(e => {
assert_equals(e.data['entryType'], 'longtask'); assert_equals(e.data['entryType'], 'longtask');
assert_equals(e.data['frame-attribution'], 'same-origin-ancestor'); assert_equals(e.data['frame-attribution'], 'same-origin-ancestor');
assert_equals(e.data['task-attribution'], 'script'); assert_equals(e.data['task-attribution'], 'unknown');
assert_equals(e.data['containerId'], ''); assert_equals(e.data['containerId'], '');
assert_equals(e.data['containerName'], ''); assert_equals(e.data['containerName'], '');
assert_equals(e.data['containerSrc'], ''); assert_equals(e.data['containerSrc'], '');
......
...@@ -29,7 +29,7 @@ ...@@ -29,7 +29,7 @@
'Exactly one attribution entry is expected'); 'Exactly one attribution entry is expected');
const attribution = longtask.attribution[0]; const attribution = longtask.attribution[0];
assert_equals(attribution.entryType, 'taskattribution'); assert_equals(attribution.entryType, 'taskattribution');
assert_equals(attribution.name, 'script'); assert_equals(attribution.name, 'unknown');
assert_equals(attribution.duration, 0); assert_equals(attribution.duration, 0);
assert_equals(attribution.startTime, 0); assert_equals(attribution.startTime, 0);
assert_equals(attribution.containerId, ''); assert_equals(attribution.containerId, '');
......
...@@ -15,7 +15,7 @@ ...@@ -15,7 +15,7 @@
window.addEventListener('message', t.step_func(e => { window.addEventListener('message', t.step_func(e => {
assert_equals(e.data['entryType'], 'longtask'); assert_equals(e.data['entryType'], 'longtask');
assert_equals(e.data['frame-attribution'], 'cross-origin-unreachable'); assert_equals(e.data['frame-attribution'], 'cross-origin-unreachable');
assert_equals(e.data['task-attribution'], 'script'); assert_equals(e.data['task-attribution'], 'unknown');
assert_equals(e.data['containerId'], ''); assert_equals(e.data['containerId'], '');
assert_equals(e.data['containerName'], ''); assert_equals(e.data['containerName'], '');
assert_equals(e.data['containerSrc'], ''); assert_equals(e.data['containerSrc'], '');
......
...@@ -15,7 +15,7 @@ ...@@ -15,7 +15,7 @@
window.addEventListener('message', t.step_func(e => { window.addEventListener('message', t.step_func(e => {
assert_equals(e.data['entryType'], 'longtask'); assert_equals(e.data['entryType'], 'longtask');
assert_equals(e.data['frame-attribution'], 'same-origin'); assert_equals(e.data['frame-attribution'], 'same-origin');
assert_equals(e.data['task-attribution'], 'script'); assert_equals(e.data['task-attribution'], 'unknown');
assert_equals(e.data['containerId'], 'longtask-iframe-id'); assert_equals(e.data['containerId'], 'longtask-iframe-id');
assert_equals(e.data['containerName'], 'longtask-iframe-name'); assert_equals(e.data['containerName'], 'longtask-iframe-name');
assert_equals(e.data['containerSrc'], 'resources/subframe-with-longtask.html'); assert_equals(e.data['containerSrc'], 'resources/subframe-with-longtask.html');
......
...@@ -48,7 +48,7 @@ PerformanceLongTaskTiming::PerformanceLongTaskTiming( ...@@ -48,7 +48,7 @@ PerformanceLongTaskTiming::PerformanceLongTaskTiming(
} else { } else {
// Only one possible task type exists currently: "script". // Only one possible task type exists currently: "script".
TaskAttributionTiming* attribution_entry = TaskAttributionTiming* attribution_entry =
TaskAttributionTiming::Create("script", "iframe", culprit_frame_src, TaskAttributionTiming::Create("unknown", "iframe", culprit_frame_src,
culprit_frame_id, culprit_frame_name); culprit_frame_id, culprit_frame_name);
attribution_.push_back(*attribution_entry); attribution_.push_back(*attribution_entry);
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment