Remove usage of is_valid from ProfileDownloader's token update callback
https://chromium-review.googlesource.com/c/chromium/src/+/1163620/ migrated ProfileDownloader to IdentityManager. As part of doing so, it naturally checked the |is_valid| parameter in ProfileDownloader:: OnRefreshTokenUpdatedForAccount(). However, this check is actually incorrect, as the being migrated *away from* was not making the equivalent check (which would have been checking PO2TS::GetAuthError() explicitly). I discovered this while going through the codebase to remove the |is_valid| parameter from this observer callback precisely to avoid this kind of confusion :). Bug: 909734 Change-Id: Iace1fbe14326aedbdd54e6e59db9ec466d8ffcdc Reviewed-on: https://chromium-review.googlesource.com/c/1353982Reviewed-by:Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#612196}
Showing
Please register or sign in to comment