Android: BuildConfig.isMultidexEnabled() -> BuildConfig.IS_MULTIDEX_ENABLED

Allows for better inlining by ProGuard.

TBR=agrieve  # Simple rename

Change-Id: If0b57507aeae938bdbe2adbd62e5d38c0d50ab4c
Reviewed-on: https://chromium-review.googlesource.com/964383Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#543451}

base/android/java/templates/BuildConfig.template

@@ -18,18 +18,11 @@ package org.chromium.base;
  */
 public class BuildConfig {
 
-    /** Whether multidex is enabled for this target.
-     *
-     *  This has to be a function instead of a static final boolean s.t. the initial false value
-     *  doesn't get optimized into {@link ChromiumMultiDexInstaller} at base_java compile time.
-     */
-    public static boolean isMultidexEnabled() {
 #if defined(ENABLE_MULTIDEX)
-        return true;
+    public static MAYBE_FINAL boolean IS_MULTIDEX_ENABLED = true;
 #else
-        return false;
+    public static MAYBE_FINAL boolean IS_MULTIDEX_ENABLED = false;
 #endif
-    }
 
 #if defined(_FIREBASE_APP_ID)
     public static MAYBE_FINAL String FIREBASE_APP_ID = QUOTE(_FIREBASE_APP_ID);

chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java

@@ -60,7 +60,7 @@ public class ChromeApplication extends Application {
         UmaUtils.recordMainEntryPointTime();
         super.attachBaseContext(context);
         checkAppBeingReplaced();
-        if (BuildConfig.isMultidexEnabled()) {
+        if (BuildConfig.IS_MULTIDEX_ENABLED) {
             ChromiumMultiDexInstaller.install(this);
         }
         ContextUtils.initApplicationContext(this);

components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java

@@ -22,7 +22,7 @@ public class ComponentsBrowserTestsApplication extends Application {
     @Override
     protected void attachBaseContext(Context base) {
         super.attachBaseContext(base);
-        if (BuildConfig.isMultidexEnabled()) {
+        if (BuildConfig.IS_MULTIDEX_ENABLED) {
             ChromiumMultiDexInstaller.install(this);
         }
         ContextUtils.initApplicationContext(this);

content/shell/android/browsertests_apk/src/org/chromium/content_browsertests_apk/ContentBrowserTestsApplication.java

@@ -22,7 +22,7 @@ public class ContentBrowserTestsApplication extends Application {
     @Override
     protected void attachBaseContext(Context base) {
         super.attachBaseContext(base);
-        if (BuildConfig.isMultidexEnabled()) {
+        if (BuildConfig.IS_MULTIDEX_ENABLED) {
             ChromiumMultiDexInstaller.install(this);
         }
         ContextUtils.initApplicationContext(this);
@@ -34,4 +34,4 @@ public class ContentBrowserTestsApplication extends Application {
         PathUtils.setPrivateDataDirectorySuffix(PRIVATE_DATA_DIRECTORY_SUFFIX);
         ApplicationStatus.initialize(this);
     }
-}
\ No newline at end of file
+}

content/shell/android/linker_test_apk/src/org/chromium/chromium_linker_test_apk/ChromiumLinkerTestApplication.java

@@ -21,7 +21,7 @@ public class ChromiumLinkerTestApplication extends Application {
     @Override
     protected void attachBaseContext(Context base) {
         super.attachBaseContext(base);
-        if (BuildConfig.isMultidexEnabled()) {
+        if (BuildConfig.IS_MULTIDEX_ENABLED) {
             ChromiumMultiDexInstaller.install(this);
         }
         ContextUtils.initApplicationContext(this);

content/shell/android/shell_apk/src/org/chromium/content_shell_apk/ContentShellApplication.java

@@ -25,7 +25,7 @@ public class ContentShellApplication extends Application {
     @Override
     protected void attachBaseContext(Context base) {
         super.attachBaseContext(base);
-        if (BuildConfig.isMultidexEnabled()) {
+        if (BuildConfig.IS_MULTIDEX_ENABLED) {
             ChromiumMultiDexInstaller.install(this);
         }
         ContextUtils.initApplicationContext(this);

testing/android/native_test/java/src/org/chromium/native_test/NativeTestApplication.java

@@ -18,7 +18,7 @@ public class NativeTestApplication extends Application {
     protected void attachBaseContext(Context base) {
         super.attachBaseContext(base);
         assert getBaseContext() != null;
-        if (BuildConfig.isMultidexEnabled()) {
+        if (BuildConfig.IS_MULTIDEX_ENABLED) {
             ChromiumMultiDexInstaller.install(this);
         }
     }