Commit 6b492077 authored by Yulun Wu's avatar Yulun Wu Committed by Commit Bot

Enable release notes in tests.

Bug: 991767
Change-Id: I26ba9da8a01a20efed9634cf9a8c462b14b999d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084719
Commit-Queue: Yulun Wu <yulunwu@chromium.org>
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: default avatarAlexander Alekseev <alemate@chromium.org>
Auto-Submit: Yulun Wu <yulunwu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746607}
parent 8778dbaf
...@@ -50,17 +50,6 @@ bool ReleaseNotesStorage::ShouldNotify() { ...@@ -50,17 +50,6 @@ bool ReleaseNotesStorage::ShouldNotify() {
chromeos::features::kReleaseNotesNotification)) chromeos::features::kReleaseNotesNotification))
return false; return false;
// TODO: remove after fixing http://crbug.com/991767.
const base::CommandLine* current_command_line =
base::CommandLine::ForCurrentProcess();
const bool is_running_test =
current_command_line->HasSwitch(::switches::kTestName) ||
current_command_line->HasSwitch(::switches::kTestType);
if (is_running_test) {
DLOG(WARNING) << "Ignoring Release Notes Notification for test.";
return false;
}
std::string user_email = profile_->GetProfileUserName(); std::string user_email = profile_->GetProfileUserName();
if (gaia::IsGoogleInternalAccountEmail(user_email) || if (gaia::IsGoogleInternalAccountEmail(user_email) ||
(ProfileHelper::Get()->GetUserByProfile(profile_)->HasGaiaAccount() && (ProfileHelper::Get()->GetUserByProfile(profile_)->HasGaiaAccount() &&
......
...@@ -241,8 +241,8 @@ const base::Feature kReleaseNotes{"ReleaseNotes", ...@@ -241,8 +241,8 @@ const base::Feature kReleaseNotes{"ReleaseNotes",
base::FEATURE_ENABLED_BY_DEFAULT}; base::FEATURE_ENABLED_BY_DEFAULT};
// Enables or disables Release Notes notifications on Chrome OS. // Enables or disables Release Notes notifications on Chrome OS.
const base::Feature kReleaseNotesNotification{ const base::Feature kReleaseNotesNotification{"ReleaseNotesNotification",
"ReleaseNotesNotification", base::FEATURE_DISABLED_BY_DEFAULT}; base::FEATURE_ENABLED_BY_DEFAULT};
// Enables or disables long kill timeout for session manager daemon. When // Enables or disables long kill timeout for session manager daemon. When
// enabled, session manager daemon waits for a longer time (e.g. 12s) for chrome // enabled, session manager daemon waits for a longer time (e.g. 12s) for chrome
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment