Add new focus following switch and flag for Chrome OS Magnifier

Bug: 1131153
AX-Relnotes: N/A
Change-Id: I3405fbbe612eeacb54673509a2b7f039eb279555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424678
Commit-Queue: Josiah Krutz <josiahk@google.com>
Auto-Submit: Josiah Krutz <josiahk@google.com>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#809677}

chrome/browser/about_flags.cc

@@ -3485,6 +3485,15 @@ const FeatureEntry kFeatureEntries[] = {
      kOsCrOS,
      SINGLE_VALUE_TYPE(
          ::switches::kEnableExperimentalAccessibilityChromeVoxTutorial)},
+    {"enable-experimental-accessibility-magnifier-new-focus-following",
+     flag_descriptions::
+         kExperimentalAccessibilityMagnifierNewFocusFollowingName,
+     flag_descriptions::
+         kExperimentalAccessibilityMagnifierNewFocusFollowingDescription,
+     kOsCrOS,
+     SINGLE_VALUE_TYPE(
+         ::switches::
+             kEnableExperimentalAccessibilityMagnifierNewFocusFollowing)},
 #endif  // OS_CHROMEOS
 #if defined(OS_MAC)
     {"enable-immersive-fullscreen-toolbar",

chrome/browser/flag-metadata.json

@@ -1482,6 +1482,11 @@
     "owners": [ "chrishall", "//ui/accessibility/OWNERS" ],
     "expiry_milestone": 87
   },
+  {
+    "name": "enable-experimental-accessibility-magnifier-new-focus-following",
+    "owners": [ "josiahk", "//ui/accessibility/OWNERS" ],
+    "expiry_milestone": 88
+  },
   {
     "name": "enable-experimental-accessibility-switch-access-text",
     "owners": [ "anastasi@google.com", "//ui/accessibility/OWNERS" ],

chrome/browser/flag_descriptions.cc

@@ -4033,6 +4033,12 @@ const char kExperimentalAccessibilityCursorColorsDescription[] =
     "Enable experimental feature which allows setting cursor color in "
     "Accessibility settings.";
 
+const char kExperimentalAccessibilityMagnifierNewFocusFollowingName[] =
+    "Enable new focus following in Magnifier";
+const char kExperimentalAccessibilityMagnifierNewFocusFollowingDescription[] =
+    "Enable experimental feature which allows more comprehensive focus "
+    "following in Magnifier.";
+
 const char kFilesAppCopyImageName[] = "Enable Copy Images from Files App";
 const char kFilesAppCopyImageDescription[] =
     "Enables the Files App to copy images selected to the system clipboard";

chrome/browser/flag_descriptions.h

@@ -2335,6 +2335,10 @@ extern const char kExperimentalAccessibilitySwitchAccessTextDescription[];
 extern const char kExperimentalAccessibilityCursorColorsName[];
 extern const char kExperimentalAccessibilityCursorColorsDescription[];
 
+extern const char kExperimentalAccessibilityMagnifierNewFocusFollowingName[];
+extern const char
+    kExperimentalAccessibilityMagnifierNewFocusFollowingDescription[];
+
 extern const char kFilesAppCopyImageName[];
 extern const char kFilesAppCopyImageDescription[];
 

tools/metrics/histograms/enums.xml

@@ -43704,6 +43704,8 @@ from previous Chrome versions.
       label="HappinessTrackingSurveysForDesktopSettingsPrivacy:disabled"/>
   <int value="966415988" label="SyncPseudoUSSPasswords:enabled"/>
   <int value="968355926" label="ExportTaggedPDF:enabled"/>
+  <int value="968715406"
+      label="enable-experimental-accessibility-magnifier-new-focus-following"/>
   <int value="969340095" label="EnableDspHotword:disabled"/>
   <int value="972228058" label="SyncUSSSessions:disabled"/>
   <int value="973601997" label="SafeBrowsingUseLocalBlacklistsV2:disabled"/>

ui/accessibility/accessibility_switches.cc

@@ -40,6 +40,11 @@ const char kEnableExperimentalAccessibilityChromeVoxAnnotations[] =
 const char kEnableExperimentalAccessibilityChromeVoxTutorial[] =
     "enable-experimental-accessibility-chromevox-tutorial";
 
+// Enables new magnifier focus following feature, which provides richer focus
+// following experience.
+const char kEnableExperimentalAccessibilityMagnifierNewFocusFollowing[] =
+    "enable-experimental-accessibility-magnifier-new-focus-following";
+
 // Enables Switch Access point scanning. This feature hasn't launched yet.
 const char kEnableSwitchAccessPointScanning[] =
     "enable-switch-access-point-scanning";

ui/accessibility/accessibility_switches.h

@@ -24,6 +24,8 @@ AX_BASE_EXPORT extern const char
     kEnableExperimentalAccessibilityChromeVoxAnnotations[];
 AX_BASE_EXPORT extern const char
     kEnableExperimentalAccessibilityChromeVoxTutorial[];
+AX_BASE_EXPORT extern const char
+    kEnableExperimentalAccessibilityMagnifierNewFocusFollowing[];
 AX_BASE_EXPORT extern const char kEnableSwitchAccessPointScanning[];
 
 // Returns true if experimental accessibility language detection is enabled.