Commit 6b6bd569 authored by Marc Treib's avatar Marc Treib Committed by Commit Bot

ProfileSyncService::InitParams: initialize all members

Let's make sure all the raw pointers are properly nulled out rather than
uninitialized. I'm not aware of any concrete problems caused by this,
but better safe than sorry.

Bug: none (AFAIK)
Change-Id: Ifae536ad37858ae264e055106bf6c2d80c2567e3
Reviewed-on: https://chromium-review.googlesource.com/c/1317606Reviewed-by: default avatarMohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#605313}
parent 1de83653
...@@ -200,7 +200,7 @@ class ProfileSyncService : public syncer::SyncService, ...@@ -200,7 +200,7 @@ class ProfileSyncService : public syncer::SyncService,
~InitParams(); ~InitParams();
std::unique_ptr<syncer::SyncClient> sync_client; std::unique_ptr<syncer::SyncClient> sync_client;
identity::IdentityManager* identity_manager; identity::IdentityManager* identity_manager = nullptr;
SigninScopedDeviceIdCallback signin_scoped_device_id_callback; SigninScopedDeviceIdCallback signin_scoped_device_id_callback;
GaiaCookieManagerService* gaia_cookie_manager_service = nullptr; GaiaCookieManagerService* gaia_cookie_manager_service = nullptr;
std::vector<invalidation::IdentityProvider*> std::vector<invalidation::IdentityProvider*>
...@@ -208,7 +208,7 @@ class ProfileSyncService : public syncer::SyncService, ...@@ -208,7 +208,7 @@ class ProfileSyncService : public syncer::SyncService,
StartBehavior start_behavior = MANUAL_START; StartBehavior start_behavior = MANUAL_START;
syncer::NetworkTimeUpdateCallback network_time_update_callback; syncer::NetworkTimeUpdateCallback network_time_update_callback;
scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory; scoped_refptr<network::SharedURLLoaderFactory> url_loader_factory;
network::NetworkConnectionTracker* network_connection_tracker; network::NetworkConnectionTracker* network_connection_tracker = nullptr;
std::string debug_identifier; std::string debug_identifier;
version_info::Channel channel = version_info::Channel::UNKNOWN; version_info::Channel channel = version_info::Channel::UNKNOWN;
bool user_events_separate_pref_group = false; bool user_events_separate_pref_group = false;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment