Commit 6b706240 authored by malets's avatar malets Committed by Commit bot

Turn deps of chromium_builder_perf into data_deps.

It seems that for "group" labels GN does not include data of dependencies
declared as "deps", but it would be convenient if we could refer to
chromium_builder_perf group to query all the runtime dependencies of the
test binaries.  This change does not touch dependency logic, though: all
the prerequisites of chromium_builder_perf continue to build as before.

The runtime_deps of this target can then be used, e.g., to make archive
with all the files required to run all (telemetry-based and binary)
performance tests.

R=jochen,thakis

Review-Url: https://codereview.chromium.org/2337153002
Cr-Commit-Position: refs/heads/master@{#418805}
parent 8023d87a
...@@ -935,7 +935,7 @@ group("chromium_builder_perf") { ...@@ -935,7 +935,7 @@ group("chromium_builder_perf") {
testonly = true testonly = true
if (!is_ios && !is_android && !is_chromecast) { if (!is_ios && !is_android && !is_chromecast) {
deps = [ data_deps = [
"//cc:cc_perftests", "//cc:cc_perftests",
"//chrome/test:load_library_perf_tests", "//chrome/test:load_library_perf_tests",
"//chrome/test:telemetry_perf_tests", "//chrome/test:telemetry_perf_tests",
...@@ -945,28 +945,28 @@ group("chromium_builder_perf") { ...@@ -945,28 +945,28 @@ group("chromium_builder_perf") {
] ]
if (!is_chromeos) { if (!is_chromeos) {
deps += [ "//chrome/test:performance_browser_tests" ] data_deps += [ "//chrome/test:performance_browser_tests" ]
} }
if (is_linux && !is_chromeos) { if (is_linux && !is_chromeos) {
if (is_official_build) { if (is_official_build) {
# In GN builds, this is controlled by the 'linux_dump_symbols' # In GN builds, this is controlled by the 'linux_dump_symbols'
# flag, which defaults to 1 for official builds. For now, # flag, which defaults to 1 for official builds. For now,
# we skip the separate flag and just key off of is_official_build. # we skip the separate flag and just key off of is_official_build.
deps += [ "//chrome:linux_symbols" ] data_deps += [ "//chrome:linux_symbols" ]
} }
if (!is_chromeos) { if (!is_chromeos) {
deps += [ "//tools/perf/clear_system_cache" ] data_deps += [ "//tools/perf/clear_system_cache" ]
} }
} }
if (is_win) { if (is_win) {
deps += [ data_deps += [
"//chrome/installer/mini_installer:mini_installer", "//chrome/installer/mini_installer:mini_installer",
"//third_party/angle/src/tests:angle_perftests", "//third_party/angle/src/tests:angle_perftests",
] ]
} else { } else {
deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ] data_deps += [ "//breakpad:minidump_stackwalk($host_toolchain)" ]
} }
} }
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment