Commit 6b71572c authored by Tarun Bansal's avatar Tarun Bansal Committed by Commit Bot

Refactor ResourceSchedulerParamsManager

Refactor the method that sets the parameters for the resource
scheduler. This CL does not introduce any functionality
change.

Bug: 897371
Change-Id: I2018e8d5662a3481d7c32ee7342f82c976979836
Reviewed-on: https://chromium-review.googlesource.com/c/1297574Reviewed-by: default avatarMatt Menke <mmenke@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602347}
parent 4aa59465
...@@ -73,31 +73,6 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) ResourceSchedulerParamsManager { ...@@ -73,31 +73,6 @@ class COMPONENT_EXPORT(NETWORK_SERVICE) ResourceSchedulerParamsManager {
} }
private: private:
// Reads the experiments params for DelayRequestsOnMultiplexedConnections
// finch experiment, modifies |result| based on the experiment params, and
// returns the modified |result|.
static ParamsForNetworkQualityContainer
GetParamsForDelayRequestsOnMultiplexedConnections(
ParamsForNetworkQualityContainer result);
// Reads experiment parameters and populates
// |params_for_network_quality_container_|. It looks for configuration
// parameters with sequential numeric suffixes, and stops looking after the
// first failure to find an experimetal parameter. A sample configuration is
// given below:
// "EffectiveConnectionType1": "Slow-2G",
// "MaxDelayableRequests1": "6",
// "NonDelayableWeight1": "2.0",
// "EffectiveConnectionType2": "3G",
// "MaxDelayableRequests2": "12",
// "NonDelayableWeight2": "3.0",
// This config implies that when Effective Connection Type (ECT) is Slow-2G,
// then the maximum number of non-delayable requests should be
// limited to 6, and the non-delayable request weight should be set to 2.
// When ECT is 3G, it should be limited to 12. For all other values of ECT,
// the default values are used.
static ParamsForNetworkQualityContainer GetParamsForNetworkQualityContainer();
// The number of delayable requests in-flight for different ranges of the // The number of delayable requests in-flight for different ranges of the
// network quality. // network quality.
ParamsForNetworkQualityContainer params_for_network_quality_container_; ParamsForNetworkQualityContainer params_for_network_quality_container_;
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment