Skip to content

GitLab

T
tangled
Commit 6bd0dace authored by mlamouri's avatar mlamouri Committed by Commit bot
Browse files
Options

Unflake media/video-poster-after-loadedmetadata.html 

Instead of having a 2 seconds timeout, using a combination of setTimeout
of 0 and requestAnimationFrame.

BUG=513398
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2586223002
Cr-Commit-Position: refs/heads/master@{#439468}
parent 6b071fe7
Hide whitespace changes
Inline Side-by-side
Showing with 7 additions and 13 deletions
third_party/WebKit/LayoutTests/TestExpectations
View file @ 6bd0dace
...@@ -716,7 +716,6 @@ crbug.com/518883 crbug.com/390452 http/tests/security/isolatedWorld/media-query- ...@@ -716,7 +716,6 @@ crbug.com/518883 crbug.com/390452 http/tests/security/isolatedWorld/media-query-
crbug.com/518883 crbug.com/390452 virtual/mojo-loading/http/tests/security/isolatedWorld/media-query-wrapper-leaks.html [ Failure Pass Timeout ] crbug.com/518883 crbug.com/390452 virtual/mojo-loading/http/tests/security/isolatedWorld/media-query-wrapper-leaks.html [ Failure Pass Timeout ]
crbug.com/518987 http/tests/xmlhttprequest/navigation-abort-detaches-frame.html [ Pass Timeout ] crbug.com/518987 http/tests/xmlhttprequest/navigation-abort-detaches-frame.html [ Pass Timeout ]
crbug.com/518989 [ Mac ] imported/csswg-test/css-writing-modes-3/writing-mode-vertical-rl-002.xht [ Failure Pass Timeout ] crbug.com/518989 [ Mac ] imported/csswg-test/css-writing-modes-3/writing-mode-vertical-rl-002.xht [ Failure Pass Timeout ]
crbug.com/518998 media/video-poster-after-loadedmetadata.html [ Failure Pass ]
crbug.com/673296 [ Android ] inspector-protocol/input/dispatchMouseEvent.html [ Pass Timeout ] crbug.com/673296 [ Android ] inspector-protocol/input/dispatchMouseEvent.html [ Pass Timeout ]
# These performance-sensitive user-timing tests are flaky in debug on all platforms, and flaky on all configurations of windows. # These performance-sensitive user-timing tests are flaky in debug on all platforms, and flaky on all configurations of windows.
......
third_party/WebKit/LayoutTests/media/video-poster-after-loadedmetadata.html
View file @ 6bd0dace
<!DOCTYPE html> <!DOCTYPE html>
<title>Tests setting the poster attribute after a video fires loadedmetadata.</title> <title>Tests setting the poster attribute after a video fires loadedmetadata.</title>
<video></video>
<script> <script>
if (window.testRunner) if (window.testRunner)
testRunner.waitUntilDone(); testRunner.waitUntilDone();
function startTest() { var video = document.querySelector('video');
var video = document.querySelector('video'); video.addEventListener("loadedmetadata", _ => {
video.addEventListener("loadedmetadata", function () { video.poster = "content/abe.png";
video.poster = "content/abe.png"; setTimeout(_ => requestAnimationFrame(_ => testRunner.notifyDone()));
if (window.testRunner) });
setTimeout(function() { testRunner.notifyDone(); }, 2000);
});
video.src = "resources/test-positive-start-time.webm";
}
window.addEventListener('load', startTest, false); video.src = "resources/test-positive-start-time.webm";
</script> </script>
<video></video>
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment