DevTools: Convert handleShortcut to Actions in the Network panel

This is part of a series of patches to remove Panel.handleShortcut

Change-Id: I9c66fa93da4ee7a1e0a12a68f09391c1c4651f7c
Reviewed-on: https://chromium-review.googlesource.com/1060513
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561703}

third_party/WebKit/LayoutTests/http/tests/devtools/network/network-close-request-view-expected.txt

+Showing request foo
+Network Item View: true
+Hiding request
+Network Item View: null
+

third_party/WebKit/LayoutTests/http/tests/devtools/network/network-close-request-view.js

+// Copyright 2018 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+(async function() {
+  await TestRunner.showPanel('network');
+
+  var panel = UI.panels.network;
+  var target = panel._networkLogView;
+  var types = Common.resourceTypes;
+
+  var requestFoo = new SDK.NetworkRequest('', '', '', '', '');
+  requestFoo.setResourceType(types.XHR);
+  requestFoo.setRequestIdForTest('foo');
+  TestRunner.addResult('Showing request foo');
+  panel._showRequest(requestFoo);
+  TestRunner.addResult('Network Item View: ' + (panel._networkItemView && panel._networkItemView.isShowing()));
+
+  TestRunner.addResult('Hiding request');
+  eventSender.keyDown('Escape');
+  await TestRunner.addSnifferPromise(Network.NetworkPanel.ActionDelegate.prototype, 'handleAction')
+  TestRunner.addResult('Network Item View: ' + (panel._networkItemView && panel._networkItemView.isShowing()));
+
+  TestRunner.completeTest();
+})();
\ No newline at end of file

third_party/blink/renderer/devtools/front_end/network/NetworkPanel.js

@@ -381,20 +381,6 @@ Network.NetworkPanel = class extends UI.Panel {
     return this._networkLogView.elementsToRestoreScrollPositionsFor();
   }
 
-  /**
-   * @override
-   * @param {!KeyboardEvent} event
-   */
-  handleShortcut(event) {
-    if (this._networkItemView && event.keyCode === UI.KeyboardShortcut.Keys.Esc.code) {
-      this._showRequest(null);
-      event.handled = true;
-      return;
-    }
-
-    super.handleShortcut(event);
-  }
-
   /**
    * @override
    */
@@ -702,7 +688,7 @@ Network.NetworkPanel.FilmStripRecorder = class {
 /**
  * @implements {UI.ActionDelegate}
  */
-Network.NetworkPanel.RecordActionDelegate = class {
+Network.NetworkPanel.ActionDelegate = class {
   /**
    * @override
    * @param {!UI.Context} context
@@ -712,8 +698,24 @@ Network.NetworkPanel.RecordActionDelegate = class {
   handleAction(context, actionId) {
     const panel = UI.context.flavor(Network.NetworkPanel);
     console.assert(panel && panel instanceof Network.NetworkPanel);
-    panel._toggleRecording();
-    return true;
+    switch (actionId) {
+      case 'network.toggle-recording':
+        panel._toggleRecording();
+        return true;
+      case 'network.hide-request-details':
+        if (!panel._networkItemView)
+          return false;
+        panel._showRequest(null);
+        return true;
+      case 'network.search':
+        const selection = UI.inspectorView.element.window().getSelection();
+        let queryCandidate = '';
+        if (selection.rangeCount)
+          queryCandidate = selection.toString().replace(/\r?\n.*/, '');
+        Network.SearchNetworkView.openSearch(queryCandidate);
+        return true;
+    }
+    return false;
   }
 };
 
@@ -766,30 +768,3 @@ Network.SearchNetworkView = class extends Search.SearchView {
     return new Network.NetworkSearchScope();
   }
 };
-
-/**
- * @implements {UI.ActionDelegate}
- */
-Network.NetworkPanel.SearchActionDelegate = class {
-  /**
-   * @override
-   * @param {!UI.Context} context
-   * @param {string} actionId
-   * @return {boolean}
-   */
-  handleAction(context, actionId) {
-    this._showSearch();
-    return true;
-  }
-
-  /**
-   * @return {!Promise}
-   */
-  _showSearch() {
-    const selection = UI.inspectorView.element.window().getSelection();
-    let queryCandidate = '';
-    if (selection.rangeCount)
-      queryCandidate = selection.toString().replace(/\r?\n.*/, '');
-    return Network.SearchNetworkView.openSearch(queryCandidate);
-  }
-};

third_party/blink/renderer/devtools/front_end/network/module.json

@@ -79,7 +79,7 @@
             "contextTypes": [
                 "Network.NetworkPanel"
             ],
-            "className": "Network.NetworkPanel.RecordActionDelegate",
+            "className": "Network.NetworkPanel.ActionDelegate",
             "options": [
                 {
                     "value": true,
@@ -101,6 +101,19 @@
                 }
             ]
         },
+        {
+            "type": "action",
+            "actionId": "network.hide-request-details",
+            "contextTypes": [
+                "Network.NetworkPanel"
+            ],
+            "className": "Network.NetworkPanel.ActionDelegate",
+            "bindings": [
+                {
+                    "shortcut": "Esc"
+                }
+            ]
+        },
         {
             "type": "view",
             "location": "drawer-view",
@@ -138,7 +151,7 @@
             "type": "action",
             "actionId": "network.search",
             "title": "Search",
-            "className": "Network.NetworkPanel.SearchActionDelegate",
+            "className": "Network.NetworkPanel.ActionDelegate",
             "contextTypes": [
                 "Network.NetworkPanel"
             ],