media: Migrate NewAudioConfigCB to repeating callback.

This callback is called from a while loop. It's run in:
* https://cs.chromium.org/chromium/src/media/formats/mp2t/es_parser_adts.cc?rcl=d027bf21fe41b297e9b0c6ed87b17973b7bb8f8d&l=179
which is called from:
* https://cs.chromium.org/chromium/src/media/formats/mp2t/es_parser_adts.cc?rcl=d027bf21fe41b297e9b0c6ed87b17973b7bb8f8d&l=297

Another example. It's run in:
* https://cs.chromium.org/chromium/src/media/formats/mp2t/es_parser_mpeg1audio.cc?rcl=d027bf21fe41b297e9b0c6ed87b17973b7bb8f8d&l=196
which is called from:
* https://cs.chromium.org/chromium/src/media/formats/mp2t/es_parser_adts.cc?rcl=d027bf21fe41b297e9b0c6ed87b17973b7bb8f8d&l=179

This is part of the base::Callback migration.

Context: https://cs.chromium.org/chromium/src/docs/callback.md?rcl=9fcc3764aea8f97e9f6de4a9ee61d554e67edcda&l=40

Bug: 1007806
Change-Id: Id10660797cf181121e0c34c581edd300fa3e23e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080268Reviewed-by: Albert J. Wong <ajwong@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: Jose Lopes <jabolopes@google.com>
Cr-Commit-Position: refs/heads/master@{#747156}

media/formats/mp2t/es_parser_adts.cc

@@ -115,10 +115,10 @@ void EsParserAdts::SkipAdtsFrame(const AdtsFrame& adts_frame) {
   es_queue_->Pop(adts_frame.size);
 }
 
-EsParserAdts::EsParserAdts(const NewAudioConfigCB& new_audio_config_cb,
+EsParserAdts::EsParserAdts(NewAudioConfigCB new_audio_config_cb,
                            EmitBufferCB emit_buffer_cb,
                            bool sbr_in_mimetype)
-    : new_audio_config_cb_(new_audio_config_cb),
+    : new_audio_config_cb_(std::move(new_audio_config_cb)),
       emit_buffer_cb_(std::move(emit_buffer_cb)),
 #if BUILDFLAG(ENABLE_HLS_SAMPLE_AES)
       get_decrypt_config_cb_(),
@@ -128,12 +128,12 @@ EsParserAdts::EsParserAdts(const NewAudioConfigCB& new_audio_config_cb,
 }
 
 #if BUILDFLAG(ENABLE_HLS_SAMPLE_AES)
-EsParserAdts::EsParserAdts(const NewAudioConfigCB& new_audio_config_cb,
+EsParserAdts::EsParserAdts(NewAudioConfigCB new_audio_config_cb,
                            EmitBufferCB emit_buffer_cb,
                            GetDecryptConfigCB get_decrypt_config_cb,
                            EncryptionScheme init_encryption_scheme,
                            bool sbr_in_mimetype)
-    : new_audio_config_cb_(new_audio_config_cb),
+    : new_audio_config_cb_(std::move(new_audio_config_cb)),
       emit_buffer_cb_(std::move(emit_buffer_cb)),
       get_decrypt_config_cb_(std::move(get_decrypt_config_cb)),
       init_encryption_scheme_(init_encryption_scheme),

media/formats/mp2t/es_parser_adts.h

@@ -31,13 +31,14 @@ namespace mp2t {
 
 class MEDIA_EXPORT EsParserAdts : public EsParser {
  public:
-  typedef base::Callback<void(const AudioDecoderConfig&)> NewAudioConfigCB;
+  using NewAudioConfigCB =
+      base::RepeatingCallback<void(const AudioDecoderConfig&)>;
 
-  EsParserAdts(const NewAudioConfigCB& new_audio_config_cb,
+  EsParserAdts(NewAudioConfigCB new_audio_config_cb,
                EmitBufferCB emit_buffer_cb,
                bool sbr_in_mimetype);
 #if BUILDFLAG(ENABLE_HLS_SAMPLE_AES)
-  EsParserAdts(const NewAudioConfigCB& new_audio_config_cb,
+  EsParserAdts(NewAudioConfigCB new_audio_config_cb,
                EmitBufferCB emit_buffer_cb,
                GetDecryptConfigCB get_decrypt_config_cb,
                EncryptionScheme init_encryption_scheme,

media/formats/mp2t/es_parser_adts_fuzzer.cc

@@ -13,7 +13,7 @@ static void EmitBuffer(scoped_refptr<media::StreamParserBuffer> buffer) {}
 
 // Entry point for LibFuzzer.
 extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
-  media::mp2t::EsParserAdts es_parser(base::Bind(&NewAudioConfig),
+  media::mp2t::EsParserAdts es_parser(base::BindRepeating(&NewAudioConfig),
                                       base::BindRepeating(&EmitBuffer), true);
   if (!es_parser.Parse(data, size, media::kNoTimestamp,
                        media::kNoDecodeTimestamp())) {

media/formats/mp2t/es_parser_adts_unittest.cc

@@ -38,11 +38,11 @@ EsParserAdtsTest::EsParserAdtsTest() {
 
 bool EsParserAdtsTest::Process(const std::vector<Packet>& pes_packets,
                                bool sbr_in_mimetype) {
-  EsParserAdts es_parser(
-      base::Bind(&EsParserAdtsTest::NewAudioConfig, base::Unretained(this)),
-      base::BindRepeating(&EsParserAdtsTest::EmitBuffer,
-                          base::Unretained(this)),
-      sbr_in_mimetype);
+  EsParserAdts es_parser(base::BindRepeating(&EsParserAdtsTest::NewAudioConfig,
+                                             base::Unretained(this)),
+                         base::BindRepeating(&EsParserAdtsTest::EmitBuffer,
+                                             base::Unretained(this)),
+                         sbr_in_mimetype);
   return ProcessPesPackets(&es_parser, pes_packets, false /* force_timing */);
 }
 

media/formats/mp2t/es_parser_mpeg1audio.h

@@ -29,7 +29,8 @@ namespace mp2t {
 
 class MEDIA_EXPORT EsParserMpeg1Audio : public EsParser {
  public:
-  typedef base::Callback<void(const AudioDecoderConfig&)> NewAudioConfigCB;
+  using NewAudioConfigCB =
+      base::RepeatingCallback<void(const AudioDecoderConfig&)>;
 
   EsParserMpeg1Audio(const NewAudioConfigCB& new_audio_config_cb,
                      EmitBufferCB emit_buffer_cb,

media/formats/mp2t/es_parser_mpeg1audio_fuzzer.cc

@@ -17,9 +17,9 @@ static void EmitBuffer(scoped_refptr<media::StreamParserBuffer> buffer) {}
 // Entry point for LibFuzzer.
 extern "C" int LLVMFuzzerTestOneInput(const uint8_t* data, size_t size) {
   media::NullMediaLog media_log;
-  media::mp2t::EsParserMpeg1Audio es_parser(base::Bind(&NewAudioConfig),
-                                            base::BindRepeating(&EmitBuffer),
-                                            &media_log);
+  media::mp2t::EsParserMpeg1Audio es_parser(
+      base::BindRepeating(&NewAudioConfig), base::BindRepeating(&EmitBuffer),
+      &media_log);
   if (es_parser.Parse(data, size, media::kNoTimestamp,
                       media::kNoDecodeTimestamp())) {
     es_parser.Flush();

media/formats/mp2t/es_parser_mpeg1audio_unittest.cc

@@ -39,8 +39,8 @@ bool EsParserMpeg1AudioTest::Process(
     const std::vector<Packet>& pes_packets,
     bool force_timing) {
   EsParserMpeg1Audio es_parser(
-      base::Bind(&EsParserMpeg1AudioTest::NewAudioConfig,
-                 base::Unretained(this)),
+      base::BindRepeating(&EsParserMpeg1AudioTest::NewAudioConfig,
+                          base::Unretained(this)),
       base::BindRepeating(&EsParserMpeg1AudioTest::EmitBuffer,
                           base::Unretained(this)),
       &media_log_);

media/formats/mp2t/mp2t_stream_parser.cc

@@ -405,7 +405,7 @@ std::unique_ptr<EsParser> Mp2tStreamParser::CreateH264Parser(int pes_pid) {
 }
 
 std::unique_ptr<EsParser> Mp2tStreamParser::CreateAacParser(int pes_pid) {
-  auto on_audio_config_changed = base::Bind(
+  auto on_audio_config_changed = base::BindRepeating(
       &Mp2tStreamParser::OnAudioConfigChanged, base::Unretained(this), pes_pid);
   auto on_emit_audio_buffer = base::BindRepeating(
       &Mp2tStreamParser::OnEmitAudioBuffer, base::Unretained(this), pes_pid);
@@ -416,7 +416,7 @@ std::unique_ptr<EsParser> Mp2tStreamParser::CreateAacParser(int pes_pid) {
 
 std::unique_ptr<EsParser> Mp2tStreamParser::CreateMpeg1AudioParser(
     int pes_pid) {
-  auto on_audio_config_changed = base::Bind(
+  auto on_audio_config_changed = base::BindRepeating(
       &Mp2tStreamParser::OnAudioConfigChanged, base::Unretained(this), pes_pid);
   auto on_emit_audio_buffer = base::BindRepeating(
       &Mp2tStreamParser::OnEmitAudioBuffer, base::Unretained(this), pes_pid);
@@ -453,7 +453,7 @@ std::unique_ptr<EsParser> Mp2tStreamParser::CreateEncryptedH264Parser(
 std::unique_ptr<EsParser> Mp2tStreamParser::CreateEncryptedAacParser(
     int pes_pid,
     bool emit_clear_buffers) {
-  auto on_audio_config_changed = base::Bind(
+  auto on_audio_config_changed = base::BindRepeating(
       &Mp2tStreamParser::OnAudioConfigChanged, base::Unretained(this), pes_pid);
   auto on_emit_audio_buffer = base::BindRepeating(
       &Mp2tStreamParser::OnEmitAudioBuffer, base::Unretained(this), pes_pid);