Commit 6c035fe0 authored by Elly Fong-Jones's avatar Elly Fong-Jones Committed by Commit Bot

cbui: remove ExtensionInstalledBubbleView CreateExtraView

After r712264 much of the controller for this class is const, so it is
now clear that it's safe to create the signin promo view once in the
constructor. Woo!

Bug: 1011446
Change-Id: I9ac5b0c9e557915594e6da17a9e58c726296bf57
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1899417Reviewed-by: default avatarPeter Boström <pbos@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#712675}
parent db540489
...@@ -113,6 +113,32 @@ views::View* AnchorViewForBrowser(ExtensionInstalledBubble* controller, ...@@ -113,6 +113,32 @@ views::View* AnchorViewForBrowser(ExtensionInstalledBubble* controller,
return reference_view; return reference_view;
} }
std::unique_ptr<views::View> CreateSigninPromoView(
int bubble_options,
Profile* profile,
BubbleSyncPromoDelegate* delegate) {
#if defined(OS_CHROMEOS)
// ChromeOS does not show the signin promo.
return nullptr;
#else
if (!(bubble_options & ExtensionInstalledBubble::SIGN_IN_PROMO))
return nullptr;
BubbleSyncPromoViewParams params;
params.link_text_resource_id = IDS_EXTENSION_INSTALLED_SYNC_PROMO_LINK_NEW;
params.message_text_resource_id = IDS_EXTENSION_INSTALLED_SYNC_PROMO_NEW;
params.dice_no_accounts_promo_message_resource_id =
IDS_EXTENSION_INSTALLED_DICE_PROMO_SIGNIN_MESSAGE;
params.dice_accounts_promo_message_resource_id =
IDS_EXTENSION_INSTALLED_DICE_PROMO_SYNC_MESSAGE;
return CreateBubbleSyncPromoView(
profile, delegate,
signin_metrics::AccessPoint::ACCESS_POINT_EXTENSION_INSTALL_BUBBLE,
params);
#endif
}
} // namespace } // namespace
// Provides feedback to the user upon successful installation of an // Provides feedback to the user upon successful installation of an
...@@ -145,7 +171,6 @@ class ExtensionInstalledBubbleView : public BubbleSyncPromoDelegate, ...@@ -145,7 +171,6 @@ class ExtensionInstalledBubbleView : public BubbleSyncPromoDelegate,
gfx::ImageSkia GetWindowIcon() override; gfx::ImageSkia GetWindowIcon() override;
bool ShouldShowWindowIcon() const override; bool ShouldShowWindowIcon() const override;
bool ShouldShowCloseButton() const override; bool ShouldShowCloseButton() const override;
std::unique_ptr<View> CreateFootnoteView() override;
int GetDialogButtons() const override; int GetDialogButtons() const override;
void Init() override; void Init() override;
...@@ -181,6 +206,8 @@ ExtensionInstalledBubbleView::ExtensionInstalledBubbleView( ...@@ -181,6 +206,8 @@ ExtensionInstalledBubbleView::ExtensionInstalledBubbleView(
bubble_reference_(bubble_reference), bubble_reference_(bubble_reference),
manage_shortcut_(nullptr) { manage_shortcut_(nullptr) {
chrome::RecordDialogCreation(chrome::DialogIdentifier::EXTENSION_INSTALLED); chrome::RecordDialogCreation(chrome::DialogIdentifier::EXTENSION_INSTALLED);
DialogDelegate::SetFootnoteView(CreateSigninPromoView(
controller->options(), controller->browser()->profile(), this));
} }
ExtensionInstalledBubbleView::~ExtensionInstalledBubbleView() {} ExtensionInstalledBubbleView::~ExtensionInstalledBubbleView() {}
...@@ -227,30 +254,6 @@ bool ExtensionInstalledBubbleView::ShouldShowWindowIcon() const { ...@@ -227,30 +254,6 @@ bool ExtensionInstalledBubbleView::ShouldShowWindowIcon() const {
return true; return true;
} }
std::unique_ptr<views::View>
ExtensionInstalledBubbleView::CreateFootnoteView() {
#if defined(OS_CHROMEOS)
// ChromeOS does not show the signin promo.
return nullptr;
#else
if (!(controller_->options() & ExtensionInstalledBubble::SIGN_IN_PROMO))
return nullptr;
BubbleSyncPromoViewParams params;
params.link_text_resource_id = IDS_EXTENSION_INSTALLED_SYNC_PROMO_LINK_NEW;
params.message_text_resource_id = IDS_EXTENSION_INSTALLED_SYNC_PROMO_NEW;
params.dice_no_accounts_promo_message_resource_id =
IDS_EXTENSION_INSTALLED_DICE_PROMO_SIGNIN_MESSAGE;
params.dice_accounts_promo_message_resource_id =
IDS_EXTENSION_INSTALLED_DICE_PROMO_SYNC_MESSAGE;
return CreateBubbleSyncPromoView(
browser()->profile(), this,
signin_metrics::AccessPoint::ACCESS_POINT_EXTENSION_INSTALL_BUBBLE,
params);
#endif
}
int ExtensionInstalledBubbleView::GetDialogButtons() const { int ExtensionInstalledBubbleView::GetDialogButtons() const {
return ui::DIALOG_BUTTON_NONE; return ui::DIALOG_BUTTON_NONE;
} }
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment