Commit 6c09107f authored by Egor Pasko's avatar Egor Pasko Committed by Commit Bot

Disable monochrome_apk_checker on bots running with Android emulator

At least one bot (see crbug.com/1137405) started failing after
crrev.com/814863 with a message:

    'unrecognized arguments: --avd-config=...'

Since a few related changes landed on top, I'm not comfortable reverting
it. Rather making the check pass with this configuration. Tested locally
by providing the same command line arguments as on the bot.

Tbr: dpranke@google.com,agrieve@chromium.org,pkotwicz@chromium.org
Bug: 1137405, 1115604
Change-Id: I28c9e3179fdbbc36ec515ed6aba8ce12f78a9417
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2464270Reviewed-by: default avatarEgor Pasko <pasko@chromium.org>
Commit-Queue: Egor Pasko <pasko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#816171}
parent 01d8e6fe
......@@ -40,6 +40,9 @@ def create_argument_parser():
parser.add_argument(
'--system-webview-pathmap',
help='The system webview APK resources pathmap path.')
parser.add_argument(
'--avd-config',
help='Workaround for crbug.com/1137405, do not use.')
return parser
......@@ -49,6 +52,12 @@ def main(argv):
runner = typ.Runner()
runner.parse_args(argument_parser, argv[1:])
# Disable all checks when --avd-config is provided because it is not supported
# by the typ.ArgumentParser(). This should happen only with tests running on
# Android emulator. TODO(crbug.com/1137405): Add support for --avd-config to
# typ.
if runner.args.avd_config:
return 0
runner.args.top_level_dirs = [ os.path.dirname(__file__) ]
runner.context = runner.args
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment