Commit 6c4973ea authored by Daniel Bratell's avatar Daniel Bratell Committed by Commit Bot

Delete unused WebCanonicalCookie::BuildCookieLine()

The BuildCookieLine() function violated layering by using
internal blink types in the blink public API but since it
wasn't used anyway it can just be deleted.

Also hide the export include from gn since it's an ugly
exception, just for debug component builds.

Bug: 800764

Change-Id: I7381e68f801e6037667d254d690faa376461e9da
Reviewed-on: https://chromium-review.googlesource.com/c/1301469Reviewed-by: default avatarKentaro Hara <haraken@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#603371}
parent 4e8ad726
...@@ -10,8 +10,7 @@ ...@@ -10,8 +10,7 @@
#include "services/network/public/mojom/restricted_cookie_manager.mojom-shared.h" #include "services/network/public/mojom/restricted_cookie_manager.mojom-shared.h"
#include "third_party/blink/public/platform/web_string.h" #include "third_party/blink/public/platform/web_string.h"
#include "third_party/blink/public/platform/web_url.h" #include "third_party/blink/public/platform/web_url.h"
#include "third_party/blink/renderer/platform/platform_export.h" #include "third_party/blink/renderer/platform/platform_export.h" // nogncheck
#include "third_party/blink/renderer/platform/wtf/forward.h"
namespace blink { namespace blink {
...@@ -60,9 +59,6 @@ class BLINK_PLATFORM_EXPORT WebCanonicalCookie { ...@@ -60,9 +59,6 @@ class BLINK_PLATFORM_EXPORT WebCanonicalCookie {
const WebString& cookie_line, const WebString& cookie_line,
base::Time creation_time); base::Time creation_time);
// Serializing, for the document.cookie API.
static String BuildCookieLine(const Vector<WebCanonicalCookie>& cookies);
static constexpr const network::mojom::CookieSameSite kDefaultSameSiteMode = static constexpr const network::mojom::CookieSameSite kDefaultSameSiteMode =
network::mojom::CookieSameSite::NO_RESTRICTION; network::mojom::CookieSameSite::NO_RESTRICTION;
static constexpr const network::mojom::CookiePriority kDefaultPriority = static constexpr const network::mojom::CookiePriority kDefaultPriority =
......
...@@ -84,16 +84,6 @@ WebCanonicalCookie& WebCanonicalCookie::operator=( ...@@ -84,16 +84,6 @@ WebCanonicalCookie& WebCanonicalCookie::operator=(
WebCanonicalCookie::~WebCanonicalCookie() = default; WebCanonicalCookie::~WebCanonicalCookie() = default;
// static
String WebCanonicalCookie::BuildCookieLine(
const Vector<WebCanonicalCookie>& cookies) {
std::vector<net::CanonicalCookie> copy;
copy.reserve(cookies.size());
for (const auto& cookie : cookies)
copy.push_back(ToNetCanonicalCookie(cookie));
return WebString::FromUTF8(net::CanonicalCookie::BuildCookieLine(copy));
}
namespace { namespace {
// TODO(crbug.com/851889): WebURL::operator GURL() is only available if // TODO(crbug.com/851889): WebURL::operator GURL() is only available if
......
...@@ -98,17 +98,4 @@ TEST(WebCanonicalCookieTest, Properties) { ...@@ -98,17 +98,4 @@ TEST(WebCanonicalCookieTest, Properties) {
} }
} }
TEST(WebCanonicalCookieTest, BuildLine) {
const WebURL url(KURL("http://example.com"));
Vector<WebCanonicalCookie> cookies;
cookies.push_back(
WebCanonicalCookie::Create(url, "a=1", base::Time::Now()).value());
EXPECT_EQ("a=1", WebCanonicalCookie::BuildCookieLine(cookies));
cookies.push_back(
WebCanonicalCookie::Create(url, "b=2", base::Time::Now()).value());
EXPECT_EQ("a=1; b=2", WebCanonicalCookie::BuildCookieLine(cookies));
}
} // namespace blink } // namespace blink
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment