Commit 6c5f1783 authored by esprehn@chromium.org's avatar esprehn@chromium.org

Don't layout when isSelfPaintingLayer() changes

I can't find any reason to do a layout when the self painting bit
changes. The code was added by hyatt a long time ago in
https://trac.webkit.org/changeset/43657 but the test he added still
passes without that code (as do the rest of the tests).

Lets just delete this layout code.

Review URL: https://codereview.chromium.org/275563002

git-svn-id: svn://svn.chromium.org/blink/trunk@173614 bbb929c8-8fbe-4397-9dbb-9b2b20218538
parent 606b1f11
......@@ -530,6 +530,7 @@ crbug.com/334269 [ Mac ] fast/text/font-variant-ligatures.html [ ImageOnlyFailur
# Failing on Mac since r168339
crbug.com/348911 [ Mac ] fast/text/international/rtl-space-in-ltr-element.html [ ImageOnlyFailure ]
Bug(esprehn) fast/repaint/opacity-change-on-overflow-float.html [ NeedsRebaseline ]
# Switching to content shell failures
crbug.com/231866 [ Lion ] fast/backgrounds/animated-gif-as-background.html [ Pass ImageOnlyFailure ]
......
......@@ -121,8 +121,6 @@ void RenderLayerModelObject::styleWillChange(StyleDifference diff, const RenderS
void RenderLayerModelObject::styleDidChange(StyleDifference diff, const RenderStyle* oldStyle)
{
bool hadTransform = hasTransform();
bool hadLayer = hasLayer();
bool layerWasSelfPainting = hadLayer && layer()->isSelfPaintingLayer();
RenderObject::styleDidChange(diff, oldStyle);
updateFromStyle();
......@@ -161,10 +159,7 @@ void RenderLayerModelObject::styleDidChange(StyleDifference diff, const RenderSt
// FIXME: Ideally we shouldn't need this setter but we can't easily infer an overflow-only layer
// from the style.
layer()->setLayerType(type);
layer()->styleChanged(diff, oldStyle);
if (hadLayer && layer()->isSelfPaintingLayer() != layerWasSelfPainting)
setChildNeedsLayout();
}
if (FrameView *frameView = view()->frameView()) {
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment