[COOP] Access reporting [11/N] Fix wrong accessing context used.
There are 3 function to get a DomWindow from an isolate: - LocalDOMWindow* EnteredDOMWindow(v8::Isolate*); - LocalDOMWindow* IncumbentDOMWindow(v8::Isolate*); - LocalDOMWindow* CurrentDOMWindow(v8::Isolate*); The difference is explained by: third_party/blink/renderer/bindings/core/v8/V8BindingDesign.md For same-origin accesses to a window's method, the wrong V8 context was used. Instead of being the "calling" context, it was the "called" context. Using IncumbentDomWindow instead of CurrentDOMWindow fixed the issue. See response from: https://bugs.chromium.org/p/chromium/issues/detail?id=1109153#c2 COOP access reporting: [ 1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294 [ 2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185 [ 3/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270472 [ 4/N] https://chromium-review.googlesource.com/c/chromium/src/+/2273120 [ 5/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309433 [ 6/N] https://chromium-review.googlesource.com/c/chromium/src/+/2308715 [ 7/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309697 [ 8/N] https://chromium-review.googlesource.com/c/chromium/src/+/2275889 [ 9/N] https://chromium-review.googlesource.com/c/chromium/src/+/2310530 [10/N] https://chromium-review.googlesource.com/c/chromium/src/+/2315024 [11/N] this patch. Bug: 1090273 Change-Id: I3da021c33af25831a242f64ff732556aa6775a46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323250Reviewed-by:Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#792671}
Showing
Please register or sign in to comment