Commit 6ccc2ce1 authored by rvargas@google.com's avatar rvargas@google.com

Base: cleanup for base.dll. Move base_switches back to the

main project.

BUG=76996
TEST=none
Review URL: http://codereview.chromium.org/7055016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@86486 0039d316-1c4b-4281-b951-d872f2087c98
parent 50a21ce8
...@@ -62,8 +62,6 @@ ...@@ -62,8 +62,6 @@
'target_name': 'base_static', 'target_name': 'base_static',
'type': 'static_library', 'type': 'static_library',
'sources': [ 'sources': [
'base_switches.cc',
'base_switches.h',
'win/pe_image.cc', 'win/pe_image.cc',
'win/pe_image.h', 'win/pe_image.h',
], ],
...@@ -77,8 +75,6 @@ ...@@ -77,8 +75,6 @@
'target_name': 'base_static_win64', 'target_name': 'base_static_win64',
'type': 'static_library', 'type': 'static_library',
'sources': [ 'sources': [
'base_switches.cc',
'base_switches.h',
'win/pe_image.cc', 'win/pe_image.cc',
'win/pe_image.h', 'win/pe_image.h',
], ],
......
...@@ -34,6 +34,8 @@ ...@@ -34,6 +34,8 @@
'base_paths_linux.cc', 'base_paths_linux.cc',
'base_paths_win.cc', 'base_paths_win.cc',
'base_paths_win.h', 'base_paths_win.h',
'base_switches.cc',
'base_switches.h',
'basictypes.h', 'basictypes.h',
'bind.h', 'bind.h',
'bind_helpers.h', 'bind_helpers.h',
...@@ -438,9 +440,6 @@ ...@@ -438,9 +440,6 @@
'../third_party/modp_b64/modp_b64.gyp:modp_b64', '../third_party/modp_b64/modp_b64.gyp:modp_b64',
'third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations', 'third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
], ],
'export_dependent_settings': [
'third_party/dynamic_annotations/dynamic_annotations.gyp:dynamic_annotations',
],
# TODO(gregoryd): direct_dependent_settings should be shared with the # TODO(gregoryd): direct_dependent_settings should be shared with the
# 64-bit target, but it doesn't work due to a bug in gyp # 64-bit target, but it doesn't work due to a bug in gyp
'direct_dependent_settings': { 'direct_dependent_settings': {
...@@ -536,7 +535,7 @@ ...@@ -536,7 +535,7 @@
[ 'component=="shared_library"', { [ 'component=="shared_library"', {
'defines': [ 'defines': [
'BASE_DLL', 'BASE_DLL',
'BASE_IMPLEMENTATION=1', 'BASE_IMPLEMENTATION',
], ],
'conditions': [ 'conditions': [
['OS=="win"', { ['OS=="win"', {
......
...@@ -8,19 +8,21 @@ ...@@ -8,19 +8,21 @@
#define BASE_BASE_SWITCHES_H_ #define BASE_BASE_SWITCHES_H_
#pragma once #pragma once
#include "base/base_api.h"
namespace switches { namespace switches {
extern const char kDebugOnStart[]; BASE_API extern const char kDebugOnStart[];
extern const char kDisableBreakpad[]; BASE_API extern const char kDisableBreakpad[];
extern const char kEnableDCHECK[]; BASE_API extern const char kEnableDCHECK[];
extern const char kFullMemoryCrashReport[]; BASE_API extern const char kFullMemoryCrashReport[];
extern const char kLocalePak[]; BASE_API extern const char kLocalePak[];
extern const char kNoErrorDialogs[]; BASE_API extern const char kNoErrorDialogs[];
extern const char kNoMessageBox[]; BASE_API extern const char kNoMessageBox[];
extern const char kTestChildProcess[]; BASE_API extern const char kTestChildProcess[];
extern const char kV[]; BASE_API extern const char kV[];
extern const char kVModule[]; BASE_API extern const char kVModule[];
extern const char kWaitForDebugger[]; BASE_API extern const char kWaitForDebugger[];
} // namespace switches } // namespace switches
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment