Local NTP, Realbox: fix [more] console errors

Pressing unmodified Delete is currently throwing.

R=mahmadi@chromium.org
Fixed: 1013833

Change-Id: Ia895d0977595562e8ea636a063a88bd663a0ebad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861113
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#705810}

chrome/browser/resources/local_ntp/local_ntp.js

@@ -1246,9 +1246,9 @@ function onRealboxKeyDown(e) {
     return matchEl.classList.contains(CLASSES.SELECTED);
   });
 
-  if (key === 'Delete' && e.shiftKey && !e.altKey && !e.ctrlKey && !e.metaKey) {
-    if (autocompleteMatches[selected].supportsDeletion) {
-      matchElBeingDeleted = matchEls[selected];
+  if (key === 'Delete') {
+    if (e.shiftKey && !e.altKey && !e.ctrlKey && !e.metaKey &&
+        autocompleteMatches[selected].supportsDeletion) {
       window.chrome.embeddedSearch.searchBox.deleteAutocompleteMatch(selected);
       e.preventDefault();
     }

chrome/test/data/local_ntp/realbox_browsertest.js

@@ -579,6 +579,24 @@ test.realbox.testSupportedDeletion = function() {
   assertEquals(newMatchesEl.children[0], document.activeElement);
 };
 
+test.realbox.testNonShiftDelete = function() {
+  test.realbox.realboxEl.value = 'hello world';
+  test.realbox.realboxEl.dispatchEvent(new CustomEvent('input'));
+
+  chrome.embeddedSearch.searchBox.onqueryautocompletedone({
+    input: test.realbox.realboxEl.value,
+    matches: [test.realbox.getSearchMatch(), test.realbox.getUrlMatch()],
+  });
+
+  const deleteKey = new KeyboardEvent('keydown', {
+    bubbles: true,
+    cancelable: true,
+    key: 'Delete',
+  });
+  test.realbox.realboxEl.dispatchEvent(deleteKey);  // Previously threw error.
+  assertFalse(deleteKey.defaultPrevented);
+};
+
 test.realbox.testRemoveIcon = function() {
   test.realbox.realboxEl.value = 'hello world';
   test.realbox.realboxEl.dispatchEvent(new CustomEvent('input'));