Skip to content

GitLab

T
tangled
Commit 6d087c27 authored by wkorman's avatar wkorman Committed by Commit bot
Browse files
Options

Paint some content for animated elements in composited animation tests. 

In SPv2 we won't create a layer for an element that paints no content.
For composited animation focused layout tests we explicitly want to
make sure the element under test is composited. Thus we must paint
some kind of content (what it is doesn't actually matter).

Here we add an 'x' as dummy text content to be painted by any element that is
intended to be animated. We could alternatively set a background color and
ensure the element has some non-empty size, but that involves more styling which
feels more intrusive.

BUG=692310
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2702483002
Cr-Commit-Position: refs/heads/master@{#453303}
parent 329d64d8
Hide whitespace changes
Inline Side-by-side
Showing with 10 additions and 18 deletions
third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2
View file @ 6d087c27
...@@ -1617,20 +1617,10 @@ Bug(none) compositing/overflow/do-not-paint-outline-into-composited-scrolling-co ...@@ -1617,20 +1617,10 @@ Bug(none) compositing/overflow/do-not-paint-outline-into-composited-scrolling-co
Bug(none) fast/table/edge-offsets.html [ Failure ] Bug(none) fast/table/edge-offsets.html [ Failure ]
# Some work remains to fully support composited animation and scrolling. # Some work remains to fully support composited animation and scrolling.
crbug.com/674317 virtual/threaded/animations/KeyframeEffectReadOnly-composited-animation.html [ Timeout ]
crbug.com/674317 virtual/threaded/animations/composited-animations-rotate-zero-degrees.html [ Timeout ]
crbug.com/674317 virtual/threaded/animations/composited-animations-simple.html [ Timeout ]
crbug.com/674317 virtual/threaded/animations/composited-animations-timing-function.html [ Timeout ]
crbug.com/674317 virtual/threaded/animations/composited-animations-translate-rotate-scale.html [ Timeout ]
crbug.com/674317 virtual/threaded/animations/composited-filter-webkit-filter.html [ Failure ] crbug.com/674317 virtual/threaded/animations/composited-filter-webkit-filter.html [ Failure ]
crbug.com/674317 virtual/threaded/animations/compositor-independent-transform-cancel.html [ Failure ] crbug.com/674317 virtual/threaded/animations/compositor-independent-transform-cancel.html [ Failure ]
crbug.com/674317 virtual/threaded/animations/compositor-start-event-timing.html [ Timeout ] crbug.com/692310 virtual/threaded/animations/sample-on-last-keyframe.html [ Timeout ]
crbug.com/674317 virtual/threaded/animations/element-animate-positive-delay.html [ Timeout ]
crbug.com/674317 virtual/threaded/animations/img-element-transform.html [ Timeout ]
crbug.com/674317 virtual/threaded/animations/inline-block-transform.html [ Timeout ]
crbug.com/674317 virtual/threaded/animations/sample-on-last-keyframe.html [ Timeout ]
crbug.com/674317 virtual/threaded/animations/skew-notsequential-compositor.html [ Failure ] crbug.com/674317 virtual/threaded/animations/skew-notsequential-compositor.html [ Failure ]
crbug.com/674317 virtual/threaded/animations/transitions-retarget.html [ Timeout ]
crbug.com/674317 virtual/threaded/animations/zoom-responsive-transform-animation.html [ Timeout ] crbug.com/674317 virtual/threaded/animations/zoom-responsive-transform-animation.html [ Timeout ]
crbug.com/674317 virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html [ Timeout ] crbug.com/674317 virtual/threaded/fast/scroll-behavior/first-scroll-runs-on-compositor.html [ Timeout ]
crbug.com/674317 virtual/threaded/fast/scroll-behavior/smooth-scroll/fixed-background-in-iframe.html [ Crash Failure ] crbug.com/674317 virtual/threaded/fast/scroll-behavior/smooth-scroll/fixed-background-in-iframe.html [ Crash Failure ]
......
third_party/WebKit/LayoutTests/animations/compositor-start-event-timing.html
View file @ 6d087c27
...@@ -15,7 +15,7 @@ ...@@ -15,7 +15,7 @@
} }
} }
</style> </style>
<body> <body>x
<script> <script>
'use strict'; 'use strict';
async_test(function(t) { async_test(function(t) {
......
third_party/WebKit/LayoutTests/animations/resources/composited-animation-test.js
View file @ 6d087c27
...@@ -34,6 +34,8 @@ class CompositedAnimationTestCommon { ...@@ -34,6 +34,8 @@ class CompositedAnimationTestCommon {
createStaticElements() { createStaticElements() {
this.error = document.createElement('span'); this.error = document.createElement('span');
this.error.style.color = 'red'; this.error.style.color = 'red';
// The element must have some painted content in order to be composited.
this.error.textContent = 'x';
document.body.appendChild(this.error); document.body.appendChild(this.error);
this.wrapper = document.createElement('div'); this.wrapper = document.createElement('div');
......
third_party/WebKit/LayoutTests/virtual/threaded/animations/KeyframeEffectReadOnly-composited-animation.html
View file @ 6d087c27
...@@ -4,8 +4,8 @@ ...@@ -4,8 +4,8 @@
<script src="../../../resources/testharness.js"></script> <script src="../../../resources/testharness.js"></script>
<script src="../../../resources/testharnessreport.js"></script> <script src="../../../resources/testharnessreport.js"></script>
<body> <body>
<div id="target"></div> <div id="target">x</div>
<div id="targetRO"></div> <div id="targetRO">x</div>
<script> <script>
"use strict"; "use strict";
......
third_party/WebKit/LayoutTests/virtual/threaded/animations/element-animate-positive-delay.html
View file @ 6d087c27
<!DOCTYPE html> <!DOCTYPE html>
<script src="../../../resources/testharness.js"></script> <script src="../../../resources/testharness.js"></script>
<script src="../../../resources/testharnessreport.js"></script> <script src="../../../resources/testharnessreport.js"></script>
<div id="target"></div> <div id="target">x</div>
<script> <script>
promise_test(function() { promise_test(function() {
var animation = target.animate({ var animation = target.animate({
......
third_party/WebKit/LayoutTests/virtual/threaded/animations/img-element-transform.html
View file @ 6d087c27
<!DOCTYPE html> <!DOCTYPE html>
<script src="../../../resources/testharness.js"></script> <script src="../../../resources/testharness.js"></script>
<script src="../../../resources/testharnessreport.js"></script> <script src="../../../resources/testharnessreport.js"></script>
<img id="target"> <img id="target" src="../../../animations/resources/green-100.png">
<script> <script>
promise_test(function() { promise_test(function() {
var animation = target.animate({transform: ['rotate(0deg)', 'rotate(180deg)']}, 100000); var animation = target.animate({transform: ['rotate(0deg)', 'rotate(180deg)']}, 100000);
......
third_party/WebKit/LayoutTests/virtual/threaded/animations/inline-block-transform.html
View file @ 6d087c27
<!DOCTYPE html> <!DOCTYPE html>
<script src="../../../resources/testharness.js"></script> <script src="../../../resources/testharness.js"></script>
<script src="../../../resources/testharnessreport.js"></script> <script src="../../../resources/testharnessreport.js"></script>
<div id=target style="display:inline-block"></div> <div id="target" style="display:inline-block">x</div>
<script> <script>
var test = async_test('inline-block should run compositor animations'); var test = async_test('inline-block should run compositor animations');
var anim = target.animate({transform: ['rotate(0deg)', 'rotate(180deg)']}, 100000); var anim = target.animate({transform: ['rotate(0deg)', 'rotate(180deg)']}, 100000);
......
third_party/WebKit/LayoutTests/virtual/threaded/animations/transitions-retarget.html
View file @ 6d087c27
<!DOCTYPE html> <!DOCTYPE html>
<script src="../../../resources/testharness.js"></script> <script src="../../../resources/testharness.js"></script>
<script src="../../../resources/testharnessreport.js"></script> <script src="../../../resources/testharnessreport.js"></script>
<div id='element'></div> <div id="element">x</div>
<style> <style>
#element { #element {
transition: transform 2000ms; transition: transform 2000ms;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment