Commit 6d12d3a6 authored by Brandon Wylie's avatar Brandon Wylie Committed by Commit Bot

Fix double animation of omnibox when talkback is enabled

calling end on the animation instead of cancel (introduced in
https://chromium-review.googlesource.com/c/chromium/src/+/1599741) is
causing the focus animation to happen twice. Changing it back to
cancel fixes the problem.

Bug: 967289
Change-Id: I9d66ad85ac63aaf0fb369af32a4a518f1cebb4a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1631947Reviewed-by: default avatarTheresa <twellington@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#663997}
parent b6836700
......@@ -1803,7 +1803,7 @@ public class ToolbarPhone extends ToolbarLayout implements Invalidator.Client, O
if (inTabSwitcherMode) {
if (mUrlFocusLayoutAnimator != null && mUrlFocusLayoutAnimator.isRunning()) {
mUrlFocusLayoutAnimator.end();
mUrlFocusLayoutAnimator.cancel();
mUrlFocusLayoutAnimator = null;
// After finishing the animation, force a re-layout of the location bar,
// so that the final translation position is correct (since onMeasure updates
......@@ -2106,7 +2106,7 @@ public class ToolbarPhone extends ToolbarLayout implements Invalidator.Client, O
private void triggerUrlFocusAnimation(final boolean hasFocus) {
if (mUrlFocusLayoutAnimator != null && mUrlFocusLayoutAnimator.isRunning()) {
mUrlFocusLayoutAnimator.end();
mUrlFocusLayoutAnimator.cancel();
mUrlFocusLayoutAnimator = null;
}
if (mExperimentalButtonAnimationRunning) mExperimentalButtonAnimator.end();
......
Markdown is supported
0%
or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment